Skip to content

Conversation

@will-sh
Copy link
Contributor

@will-sh will-sh commented Jan 22, 2024

What changes were proposed in this pull request?

HDDS-6796. Extract method for building OMRequest in TrashOzoneFileSystem

Please describe your PR in detail:

  • Declare the createOMRequest Throws IOException
  • In the calling method:
omRequest = createOMRequest(OzoneManagerProtocolProtos.Type.RenameKey)
              .setRenameKeyRequest(renameKeyRequest)
              .build();

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6796

How was this patch tested?

Locally build successfully by:
mvn clean install -DskipTests -DskipShade
CI passed on the fork git repo.)

Copy link
Contributor

@sadanand48 sadanand48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @will-sh for the patch, looks good to me.

@will-sh
Copy link
Contributor Author

will-sh commented Jan 22, 2024

Thanks @sadanand48 for review.

@adoroszlai adoroszlai merged commit 9489d7e into apache:master Jan 22, 2024
@adoroszlai
Copy link
Contributor

Thanks @will-sh for the patch, @sadanand48 for the review.

Tejaskriya pushed a commit to Tejaskriya/ozone that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants