HDDS-10178. Shaded Jar build failure in case-insensitive filesystem #6045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamirishi
approved these changes
Jan 22, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch, this looks good to me. @adoroszlai I will discard the other PR in favour of this one
adoroszlai
changed the title
Contributor
Author
|
Thanks @swamirishi for the review. |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Jan 24, 2024
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jan 25, 2024
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…pache#6045) (cherry picked from commit 37213b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
plexus-archiver4.2.2 formaven-dependency-plugin. 4.2.3+ has broken behavior on case-insensitive filesystem (e.g. macOS). codehaus-plexus/plexus-archiver@efd980dhttps://issues.apache.org/jira/browse/HDDS-10178
How was this patch tested?
Compile on macOS failed without the fix:
https://github.com/adoroszlai/ozone/actions/runs/7599905583/job/20697742175#step:7:3286
Passed with the fix:
https://github.com/adoroszlai/ozone/actions/runs/7602214715/job/20702677091