Skip to content

HDDS-10162. Correct the metric names within OMPerformanceMetrics #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 1 commit into from
Jan 20, 2024
Merged

HDDS-10162. Correct the metric names within OMPerformanceMetrics #6035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...op-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMPerformanceMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ public static void unregister() {
private MutableRate createRatisRequestLatencyNs;

@Metric(about = "Convert ratis response to om response nano seconds")
private MutableRate createOmResoonseLatencyNs;
private MutableRate createOmResponseLatencyNs;

@Metric(about = "Ratis local command execution latency in nano seconds")
private MutableRate validateAndUpdateCacneLatencyNs;
private MutableRate validateAndUpdateCacheLatencyNs;

@Metric(about = "ACLs check latency in listKeys")
private MutableRate listKeysAclCheckLatencyNs;
Expand Down Expand Up @@ -209,11 +209,11 @@ public MutableRate getCreateRatisRequestLatencyNs() {
}

public MutableRate getCreateOmResponseLatencyNs() {
return createOmResoonseLatencyNs;
return createOmResponseLatencyNs;
}

public MutableRate getValidateAndUpdateCacneLatencyNs() {
return validateAndUpdateCacneLatencyNs;
public MutableRate getValidateAndUpdateCacheLatencyNs() {
return validateAndUpdateCacheLatencyNs;
}

public MutableRate getListKeysAclCheckLatencyNs() {
Expand Down
2 changes: 1 addition & 1 deletion ...-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ public OMClientResponse handleWriteRequest(OMRequest omRequest, TermIndex termIn
OMClientRequest omClientRequest =
OzoneManagerRatisUtils.createClientRequest(omRequest, impl);
return captureLatencyNs(
impl.getPerfMetrics().getValidateAndUpdateCacneLatencyNs(),
impl.getPerfMetrics().getValidateAndUpdateCacheLatencyNs(),
() -> {
OMClientResponse omClientResponse =
omClientRequest.validateAndUpdateCache(getOzoneManager(), termIndex);
Expand Down