Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Download of zlib fails with 403 Forbidden in CI:

Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.7.1:wget (zlib source download) on project hdds-rocks-native: Download failed with code 403: Forbidden

The same goal works locally:

mvn -N com.googlecode.maven-download-plugin:download-maven-plugin:1.7.1:wget \
  -Ddownload.url=https://zlib.net/fossils/zlib-1.2.13.tar.gz \
  -Ddownload.outputDirectory=. \
  -Ddownload.outputFileName=zlib-1.2.13.tar.gz

The patch allows overriding the official URL by setting -Dzlib.url, and does so in native.sh, which is run in unit (native) check in CI.

https://issues.apache.org/jira/browse/HDDS-10157

How was this patch tested?

CI (native only):
https://github.com/adoroszlai/ozone/actions/runs/7568517329/job/20609886518

Regular CI still in progress:
https://github.com/adoroszlai/ozone/actions/runs/7568646511

@adoroszlai adoroszlai added the CI label Jan 18, 2024
@adoroszlai adoroszlai self-assigned this Jan 18, 2024
@adoroszlai adoroszlai marked this pull request as ready for review January 18, 2024 11:00
@adoroszlai
Copy link
Contributor Author

@hemantk-12 @smengcl please review

Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the patch.

LGTM.

@adoroszlai
Copy link
Contributor Author

@smengcl would you like to take a look?

@adoroszlai adoroszlai merged commit 48d547c into apache:master Jan 18, 2024
@adoroszlai adoroszlai deleted the HDDS-10157 branch January 18, 2024 16:28
@adoroszlai
Copy link
Contributor Author

Thanks @hemantk-12 for the review.

I merged this to unblock other PRs. @smengcl please feel free to file a follow-up task if needed.

@smengcl
Copy link
Contributor

smengcl commented Jan 19, 2024

Thanks @hemantk-12 for the review.

I merged this to unblock other PRs. @smengcl please feel free to file a follow-up task if needed.

Looks good. Thanks @adoroszlai ! cc @swamirishi

@swamirishi
Copy link
Contributor

Looks good to me as well. Thanks for the patch @adoroszlai

Tejaskriya pushed a commit to Tejaskriya/ozone that referenced this pull request Jan 24, 2024
adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants