Skip to content

HDDS-3849. Add tests to show rule status of scm safemode. #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aryangupta1998 merged 1 commit into from
Jan 18, 2024
Merged

HDDS-3849. Add tests to show rule status of scm safemode. #6027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion .../server-scm/src/test/java/org/apache/hadoop/hdds/scm/safemode/TestSCMSafeModeManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,13 @@
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;

import org.apache.commons.lang3.tuple.Pair;
import org.apache.hadoop.fs.FileUtil;
import org.apache.hadoop.hdds.HddsConfigKeys;
import org.apache.hadoop.hdds.client.RatisReplicationConfig;
Expand Down Expand Up @@ -135,6 +138,7 @@ private void testSafeMode(int numContainers) throws Exception {
serviceManager, scmContext);

assertTrue(scmSafeModeManager.getInSafeMode());
validateRuleStatus("DatanodeSafeModeRule", "registered datanodes 0");
queue.fireEvent(SCMEvents.NODE_REGISTRATION_CONT_REPORT,
HddsTestUtils.createNodeRegistrationContainerReport(containers));

Expand Down Expand Up @@ -176,7 +180,8 @@ public void testSafeModeExitRule() throws Exception {
.getNumContainerWithOneReplicaReportedThreshold().value());

assertTrue(scmSafeModeManager.getInSafeMode());

validateRuleStatus("ContainerSafeModeRule",
"% of containers with at least one reported");
testContainerThreshold(containers.subList(0, 25), 0.25);
assertEquals(25, scmSafeModeManager.getSafeModeMetrics()
.getCurrentContainersWithOneReplicaReportedCount().value());
Expand Down Expand Up @@ -316,6 +321,13 @@ public void testSafeModeExitRuleWithPipelineAvailabilityCheck(
scmContext);

assertTrue(scmSafeModeManager.getInSafeMode());
if (healthyPipelinePercent > 0) {
validateRuleStatus("HealthyPipelineSafeModeRule",
"healthy Ratis/THREE pipelines");
}
validateRuleStatus("OneReplicaPipelineSafeModeRule",
"reported Ratis/THREE pipelines with at least one datanode");

testContainerThreshold(containers, 1.0);

List<Pipeline> pipelines = pipelineManager.getPipelines();
Expand Down Expand Up @@ -374,6 +386,22 @@ public void testSafeModeExitRuleWithPipelineAvailabilityCheck(
100, 1000 * 5);
}

/**
* @param safeModeRule verify that this rule is not satisfied
* @param stringToMatch string to match in the rule status.
*/
private void validateRuleStatus(String safeModeRule, String stringToMatch) {
Set<Map.Entry<String, Pair<Boolean, String>>> ruleStatuses =
scmSafeModeManager.getRuleStatus().entrySet();
for (Map.Entry<String, Pair<Boolean, String>> entry : ruleStatuses) {
if (entry.getKey().equals(safeModeRule)) {
Pair<Boolean, String> value = entry.getValue();
assertEquals(false, value.getLeft());
assertTrue(value.getRight().contains(stringToMatch));
}
}
}

private void checkHealthy(int expectedCount) throws Exception {
GenericTestUtils.waitFor(() -> scmSafeModeManager
.getHealthyPipelineSafeModeRule()
Expand Down