HDDS-10155. Use getOzoneKey when calculating the paths for keys #6023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1cb7e1958159c94170fb2376ba0ed26bc9df511c
kerneltime
changed the title
swamirishi
approved these changes
Jan 18, 2024
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
@kerneltime thanks for the patch. Changes look good to me
Contributor
|
Thanks @kerneltime for the patch, @swamirishi for the review. |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a minor clean up, the logic for calculating paths is reimplemented in many places. Using HDDS-10153 as an umbrella Jira to clean up the instances.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10155
How was this patch tested?
Existing tests