-
Notifications
You must be signed in to change notification settings - Fork 587
HDDS-10142. Add hidden command to set bucket encryption key to fix HDDS-7449 #6020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adoroszlai, @fapifta could you please take a look? Thanks |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanvipenumudy for the patch.
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/SetEncryptionKey.java
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/SetEncryptionKey.java
Outdated
Show resolved
Hide resolved
|
Thanks @tanvipenumudy for updating the patch. I'll let others take a look before merging it. |
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @tanvipenumudy
|
Thanks @tanvipenumudy for the patch, @errose28 for the review. |
What changes were proposed in this pull request?
Due to a known bug: 'HDDS-7449. Avoid overwriting bucket encryption properties when quota/replication config are set on an existing bucket', there can be consumers on a previous version of Ozone who could possibly run into this issue of losing bucket encryption properties when they (re)set quota or bucket replication configurations - which is a critical issue.
Through this patch, we can reset the BEK (bucket encryption key) of buckets affected by this bug through Ozone shell (
ozone sh bucket set-encryption-key -k <enckey> <vol>/<buck>).It does not change any other properties of the bucket or the properties of existing keys in the given bucket.
fileEncryptionInfoobject on the key-level gets generated as expected).Under normal circumstances, we do not intend for users to (re)set bucket encryption post bucket creation. Therefore, the setter methods introduced, as well as the CLI class have been put behind a
@Deprecatedannotation.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10142
How was this patch tested?