Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Fix TestSecureOzoneManager failure when run with Java 17 (see HADOOP-17910 for similar issue):

AssertionFailedError: expected: <Can't get SCM signed certificate. omRpcAdd: om-unknown:9862> but was: <Can't get SCM signed certificate. omRpcAdd: om-unknown/<unresolved>:9862>

Additionally, some cleanup (as separate commits).

https://issues.apache.org/jira/browse/HDDS-10130

How was this patch tested?

$ JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 \
  ./hadoop-ozone/dev-support/checks/junit.sh -DexcludedGroups=unhealthy \
  -am -pl :ozone-integration-test -Dtest='TestSecureOzoneManager'
...
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.891 s -- in org.apache.hadoop.ozone.om.TestSecureOzoneManager

CI (still with Java 8):
https://github.com/adoroszlai/ozone/actions/runs/7538490881

@adoroszlai adoroszlai self-assigned this Jan 16, 2024
Copy link
Contributor

@sodonnel sodonnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - seems the unresolved error message has changed in JDK 17, so the error we look for is slightly different.

@adoroszlai adoroszlai merged commit ccaf2df into apache:master Jan 17, 2024
@adoroszlai adoroszlai deleted the HDDS-10130 branch January 17, 2024 11:22
@adoroszlai
Copy link
Contributor Author

Thanks @sodonnel for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants