HDDS-10104. [hsync] Introduce soft limit support for lease recovery #5974
Conversation
| throw new OMException("Open Key " + dbOpenFileKey + " not found in openKeyTable", KEY_NOT_FOUND); | ||
| } | ||
|
|
||
| final long leaseSoftLimit = ozoneManager.getConfiguration() |
There was a problem hiding this comment.
We should move this check before the OzoneConsts.LEASE_RECOVERY already exists check, otherwise, the second call of recoverLease will fail due to this soft limit check.
| // Call second time inside soft limit, it should fail | ||
| omClientResponse = validateAndUpdateCache(); | ||
| OMResponse omResponse = omClientResponse.getOMResponse(); | ||
| Assertions.assertEquals(OzoneManagerProtocolProtos.Status.KEY_UNDER_LEASE_SOFT_LIMIT_PERIOD, |
There was a problem hiding this comment.
The second call should success. The soft limit period is to prevent recoveror to recover the client too soon when there is still client writing to this file. When the file is already under recovery, the soft limit period will have no use.
|
To be compatible with HDFS behavior, we may need to introduce one more "bool force" filed in RecoverLeaseRequest, if force is true, then this soft limit will be ignored. |
Added force option. |
| Assertions.assertEquals(OzoneManagerProtocolProtos.Status.OK, omResponse.getStatus()); | ||
| recoverLeaseResponse = omResponse.getRecoverLeaseResponse(); | ||
| keyInfo = recoverLeaseResponse.getKeyInfo(); | ||
| Assertions.assertNotNull(keyInfo); |
There was a problem hiding this comment.
@ashishkumar50, could you test the both force and non-force case in this testLeaseSoftLimitForHsyncRecoverFile ? Try the Parametrized test.
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
The last patch looks good to me. @jojochuang , could you like to take another look?
|
Merged. Thanks @ashishkumar50 and @ChenSammi |
…pache#5974) Co-authored-by: ashishk <[email protected]>
…pache#5974) Co-authored-by: ashishk <[email protected]>
…pache#5974) Co-authored-by: ashishk <[email protected]>
smengcl
changed the title
…pache#5974) Co-authored-by: ashishk <[email protected]>
…pache#5974) Co-authored-by: ashishk <[email protected]>
4 participants
What changes were proposed in this pull request?
A new property “ozone.om.lease.soft.limit”(default 60s) is added to control hsync lease recover. Any request try to recover an open file which is updated within last “ozone.om.lease.soft.limit” period will be rejected.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10104
How was this patch tested?
New unit test and existing test.