HDDS-10093. Make recoverLease call idempotent #5958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishkumar50
approved these changes
Jan 10, 2024
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
Thanks for the patch, change LGTM.
Contributor
Author
|
Thanks @jojochuang and @ashishkumar50 for the code review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jan 17, 2024
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jan 17, 2024
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jan 17, 2024
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
chungen0126
pushed a commit
to chungen0126/ozone
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To be compatible with HDFS behavior, once a file is recovered by calling recoverLease, next time call recoverLease with same path will succeed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10093
How was this patch tested?
new unit test case