HDDS-10061. NPE when container is loaded with missing container DB #5921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errose28
reviewed
Jan 4, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for fixing this @sumitagrawl. Change LGTM but can you add a test as well to make sure that invalid containers missing a container file or DB are not loaded into the datanode on startup?
kerneltime
reviewed
Jan 4, 2024
| "Skipping loading of this container.", containerID); | ||
| // Don't further process this container, as it is missing db file. | ||
| return; | ||
| throw new IOException("Container DB file is missing"); |
Contributor
There was a problem hiding this comment.
Include the container ID in the exception.
errose28
approved these changes
Jan 5, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the updates @sumitagrawl LGTM just one minor comment.
...r-service/src/test/java/org/apache/hadoop/ozone/container/ozoneimpl/TestContainerReader.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ethan Rose <[email protected]>
errose28
approved these changes
Jan 5, 2024
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai LGTM once CI passes.
Contributor
|
Thanks @sumitagrawl for the patch, @errose28, @kerneltime for the review. |
ivandika3
pushed a commit
to ivandika3/ozone
that referenced
this pull request
Oct 12, 2025
…pache#5921) (cherry picked from commit 702a385)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…tainer DB (apache#5921) Change-Id: If44641fac4b202e8ada1bf1012f3e4087d8fa7cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
when container db is not available, throw IOException so that its not loaded to memory. Log also represent for not loading the container but seems not handled properly.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10061
How was this patch tested?