HDDS-10000. Improve LeakDetector #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongkame
approved these changes
Jan 4, 2024
Contributor
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai , LGTM.
| */ | ||
| package org.apache.hadoop.hdds.utils; | ||
|
|
||
| import org.apache.ratis.util.UncheckedAutoCloseable; |
Contributor
There was a problem hiding this comment.
I don't love that Ozone depends on ratis for such a basic need. I guess it's ok for this PR as it's a general issue in Ozone.
Contributor
Author
There was a problem hiding this comment.
For now I think of Ratis as a library that provides Raft-implementation as well as useful utilities used by both Ratis and Ozone. The problem is that we don't have a top-level "utilities" Apache (or Apache-licensed other) project.
Contributor
Author
|
Thanks @duongkame for the review. |
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Mar 5, 2024
(cherry picked from commit 6df0237)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LeakTrackerimplementUncheckedAutoCloseableand change methods that return it to use the interface. Tracked objects should not call other methods exposed due toLeakTracker extends WeakReference.TestLeakDetector.https://issues.apache.org/jira/browse/HDDS-10000
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7401596618