HDDS-8982. Prevent infinite loop in WritableRatisContainerProvider if pipeline's nodes are not found #5911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s nodes are not found
Contributor
Author
|
@DaveTeng0 please take a look |
Contributor
|
Thanks @adoroszlai ! The changes look good! |
nandakumar131
approved these changes
Jan 5, 2024
Contributor
nandakumar131
left a comment
nandakumar131
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the fix. LGTM.
Contributor
Author
|
Thanks @DaveTeng0, @nandakumar131, @sodonnel for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…s nodes are not found (apache#5911) (cherry picked from commit 3f3deef)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…s nodes are not found (apache#5911) (cherry picked from commit 3f3deef)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…s nodes are not found (apache#5911) (cherry picked from commit 3f3deef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
WritableRatisContainerProvider.getContainerlogic from:to:
The original logic may keep finding the same pipeline until it is closed.
https://issues.apache.org/jira/browse/HDDS-8982
How was this patch tested?
Added unit and integration test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/7391181618