HDDS-10028. Simplify Maven cache for dependencies in CI #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
changed the title
szetszwo
approved these changes
Jan 1, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Jan 25, 2024
(cherry picked from commit 25886f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
licensecheck should use Maven cache for dependencies.cache/restorein all checks exceptbuild. This avoids the need for separate cache keys in concurrent checks, since onlybuildwill save cache.pathexception to avoid the need to explicitly delete Ozone artifacts before cache upload.https://issues.apache.org/jira/browse/HDDS-10028
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7355754873