HDDS-10027. NPE in VolumeInfoMetrics.getCommitted() #5885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
approved these changes
Dec 29, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for reporting the bug, reviewing and merging the PR. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit ec2634d)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit ec2634d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix NPE in
HddsVolume.getCommitted(), which can happen for failed volumes.https://issues.apache.org/jira/browse/HDDS-10027
How was this patch tested?
Added assertion unit test.
CI:
https://github.com/adoroszlai/ozone/actions/runs/7355440841