HDDS-10007. Rename ManagedSstFileReader in rocksdb-checkpoint-differ #5859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested review from
aswinshakil,
duongkame,
hemantk-12 and
swamirishi
swamirishi
approved these changes
Dec 29, 2023
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai . Changes look good to me
Contributor
Author
|
Thanks @swamirishi for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…pache#5859) (cherry picked from commit ddc19e9)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…pache#5859) (cherry picked from commit ddc19e9)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
…pache#5859) (cherry picked from commit ddc19e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename
ManagedSstFileReaderinrocksdb-checkpoint-differto avoid confusion with the "real"ManagedSstFileReaderfromhdds-managed-rocksdb.ozone/hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedSstFileReader.java
Lines 23 to 26 in f9167a3
ozone/hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/ManagedSstFileReader.java
Lines 48 to 52 in f9167a3
I think
SstFileSetReaderwould be a better name.https://issues.apache.org/jira/browse/HDDS-10007
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7309005071