HDDS-9936. Create a DispatcherContext for ReadChunk and GetSmallFile. #5805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongkame
reviewed
Dec 16, 2023
| if (popStream != null) { | ||
| IOUtils.close(LOG, popStream); | ||
| } | ||
| if (context != null) { |
Contributor
There was a problem hiding this comment.
Similar context creation/close should be done for ContainerStateMachine#readStateMachineData?
Contributor
Author
There was a problem hiding this comment.
@duongkame , Good catch! We should if we make DispatcherContext closable for releasing buffers.
On a second thought, HDDS-7117 already has changed using MappedByteBuffer instead of allocating buffers when the size is larger than ozone.chunk.read.mapped.buffer.threshold (default 32KB). So, it seems that we don't have do anything for read. Could you test HDDS-9536 with the current code?
(Revised: fixed typo: "small" -> "larger")
Contributor
Contributor
Author
There was a problem hiding this comment.
Sure, let's close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ReadChunkandGetSmallFilecurrently do not really require aDispatcherContext. So HDDS-9697 set a constant context for them.In this pull request, we change it to creating a new
DispatcherContextforReadChunkandGetSmallFile. It is required by HDDS-9536 for storing the read buffers in order to release the buffers after the operation has completed.What is the link to the Apache JIRA
HDDS-9936
How was this patch tested?
Updating some tests.