Skip to content

Conversation

@jyotirmoy-gh
Copy link
Contributor

What changes were proposed in this pull request?

Fix IllegalFormatConversionException error in verbose snapshot info output -

bash-4.2$ ozone sh --verbose snapshot info vol1/buck1 snap1
Volume Name : vol1
Bucket Name : buck1
Snapshot info for snapshot: snap1 under o3://vol1/buck1
{
  "volumeName" : "vol1",
  "bucketName" : "buck1",
  "name" : "snap1",
  "creationTime" : 1702290098747,
  "snapshotStatus" : "SNAPSHOT_ACTIVE",
  "snapshotId" : "cd856ae2-cea4-499c-82b0-b91ce07b9d2d",
  "snapshotPath" : "vol1/buck1",
  "checkpointDir" : "-cd856ae2-cea4-499c-82b0-b91ce07b9d2d",
  "referencedSize" : 0,
  "referencedReplicatedSize" : 0,
  "exclusiveSize" : 0,
  "exclusiveReplicatedSize" : 0
}

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9892

How was this patch tested?

Tested on docker

@jyotirmoy-gh
Copy link
Contributor Author

@hemantk-12 @swamirishi @nilotpalnandi - Please review

Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jyotirmoy-gh.

Overall looks good to me. Left a comment.

Also check why build is failing? You may need to rebase it.

Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase your fork with upstream master? Build is failing in workflow.

@hemantk-12
Copy link
Contributor

hemantk-12 commented Dec 11, 2023

@jyotirmoy-gh building is failing because of compile error caused by HDDS-9816 and HDDS-9303.

Please rebase after #5764 is merged.

@adoroszlai adoroszlai changed the title HDDS-9892. [snapshot] Verbose output of snapshot info command throws IllegalFormatConversionException HDDS-9892. ozone sh --verbose snapshot info throws IllegalFormatConversionException Dec 11, 2023
@adoroszlai adoroszlai merged commit 29c5761 into apache:master Dec 11, 2023
@adoroszlai
Copy link
Contributor

Thanks @jyotirmoy-gh for the patch, @hemantk-12 for the review.

@jyotirmoy-gh jyotirmoy-gh deleted the HDDS-9892 branch December 12, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants