Skip to content

HDDS-9816. NPE for access to MXBean during shutdown of OM #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadanand48 merged 16 commits into from
Dec 11, 2023
Merged

HDDS-9816. NPE for access to MXBean during shutdown of OM #5709

Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a29de01
HDDS-9110. Bucket owner is getting unset on setting quota on that bucket
sumitagrawl Aug 2, 2023
d221c68
Merge branch 'apache:master' into master
sumitagrawl Aug 4, 2023
7b33e69
Merge branch 'apache:master' into master
sumitagrawl Aug 14, 2023
10d26b1
Merge branch 'apache:master' into master
sumitagrawl Aug 14, 2023
a04e3d6
Merge branch 'apache:master' into master
sumitagrawl Aug 21, 2023
35b5140
Merge branch 'apache:master' into master
sumitagrawl Aug 29, 2023
be9696b
Merge branch 'apache:master' into master
sumitagrawl Sep 12, 2023
af2d8eb
Merge branch 'apache:master' into master
sumitagrawl Sep 22, 2023
53887c5
Merge branch 'apache:master' into master
sumitagrawl Oct 6, 2023
abe1a05
Merge branch 'apache:master' into master
sumitagrawl Oct 17, 2023
7971a5a
Merge branch 'apache:master' into master
sumitagrawl Oct 31, 2023
00be328
Merge branch 'apache:master' into master
sumitagrawl Nov 9, 2023
a9ea8d4
Merge branch 'apache:master' into master
sumitagrawl Nov 30, 2023
9d2aeb6
HDDS-9816. NPE for access to MXBean during shutdown of OM
sumitagrawl Dec 1, 2023
2519d6f
HDDS-9816. NPE for access to MXBean during shutdown of OM
sumitagrawl Dec 5, 2023
61e2881
HDDS-9816. NPE for access to MXBean during shutdown of OM
sumitagrawl Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2223,7 +2223,6 @@ public boolean stop() {
}
if (omRatisServer != null) {
omRatisServer.stop();
omRatisServer = null;
OMHAMetrics.unRegister();
}
isOmRpcServerRunning = false;
Expand Down Expand Up @@ -2260,6 +2259,7 @@ public boolean stop() {
if (omhaMetrics != null) {
OMHAMetrics.unRegister();
}
omRatisServer = null;
return true;
} catch (Exception e) {
LOG.error("OzoneManager stop failed.", e);
Expand Down Expand Up @@ -3031,7 +3031,7 @@ public String getRatisRoles() {
List<ServiceInfo> serviceList;
int port = omNodeDetails.getRatisPort();
RaftPeer leaderId;
if (isRatisEnabled) {
if (isRatisEnabled && null != omRatisServer) {
Copy link
Contributor

@kerneltime kerneltime Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else is redundant at the end, also change the string to `Ratis disable or server shutting down"?

try {
leaderId = omRatisServer.getLeader();
if (leaderId == null) {
Expand Down