Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps org.apache.maven.plugins:maven-clean-plugin from 2.5 to 3.3.2.

Release notes

Sourced from org.apache.maven.plugins:maven-clean-plugin's releases.

3.3.2

What's Changed

New Contributors

Full Changelog: apache/maven-clean-plugin@maven-clean-plugin-3.3.1...maven-clean-plugin-3.3.2

3.3.1

What's Changed

New Contributors

Full Changelog: apache/maven-clean-plugin@maven-clean-plugin-3.2.0...maven-clean-plugin-3.3.1

3.2.0

What's Changed

New Contributors

Full Changelog: apache/maven-clean-plugin@maven-clean-plugin-3.1.0...maven-clean-plugin-3.2.0

3.1.0

Full Changelog: https://github.com/apache/maven-clean-plugin/commits/maven-clean-plugin-3.1.0

Commits
  • 28759c4 [maven-release-plugin] prepare release maven-clean-plugin-3.3.2
  • 8d533d9 [MCLEAN-114] Refresh download page
  • 536c367 [MCLEAN-111] Fix fast delete feature for filesets (#32)
  • 4bb70fd Grammer mistake fixed
  • cbdff3b [MCLEAN-113] Downgrade plexus-xml to 3.0.0
  • 06876c1 [MCLEAN-112] Bump parent to 40
  • f698995 Type: fill --> file (#28)
  • aa91a87 [maven-release-plugin] prepare for next development iteration
  • 9a76f97 [maven-release-plugin] prepare release maven-clean-plugin-3.3.1
  • 91e81a2 Move plexus-xml to the provided scope
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

…n-clean-plugin

Bumps [org.apache.maven.plugins:maven-clean-plugin](https://github.com/apache/maven-clean-plugin) from 2.5 to 3.3.2.
- [Release notes](https://github.com/apache/maven-clean-plugin/releases)
- [Commits](apache/maven-clean-plugin@maven-clean-plugin-2.5...maven-clean-plugin-3.3.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-clean-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java labels Nov 13, 2023
@errose28
Copy link
Contributor

errose28 commented Nov 13, 2023

Hi @devabhishekpal @adoroszlai it looks like there's still some CI issues for dependabot PRs like this one. Are these regressions from #5538 or different issues?

  • Test jobs are running twice.
  • Should skip title check for dependabot PRs.
  • Fix sonar token issue or skip sonar check. See the failure from this PR.

@adoroszlai
Copy link
Contributor

@errose28 thanks for highlighting these issues.

  • Test jobs are running twice.

Dependabot creates its branch in apache/ozone repo, not in its own fork. Both push and pull_request workflows appear in the PR. With "branch in fork" (regular contribution model) only the pull_request workflow appears here, push workflow is visible in fork only. But the total number of jobs is the same in both cases.

  • Should skip title check for dependabot PRs.

I don't think so. We still need to manually create Apache Jira issue, update the PR title, and pay attention to use PR title when merging. Until these can be automated, I'd prefer having the failing title check.

  • Fix sonar token issue or skip sonar check.

Already working on it: HDDS-9682, #5599. (Since I tested it by pushing to apache/ozone, that PR also shows push jobs.)

@adoroszlai adoroszlai changed the title [Java] Dependabot Package Upgrade: Bump org.apache.maven.plugins:maven-clean-plugin from 2.5 to 3.3.2 HDDS-9689. Bump maven-clean-plugin to 3.3.2 Nov 14, 2023
@errose28
Copy link
Contributor

Thanks for looking into this @adoroszlai. If we are planning to file Jiras for dependabot changes then I think the title check makes sense. Your explanation for why the jobs are running twice makes sense as well. Should we edit the checks so that they only run once if the repos of the source and target branches are the same?

@adoroszlai
Copy link
Contributor

Should we edit the checks so that they only run once if the repos of the source and target branches are the same?

Do you mean if they are in the same repo? Normally it makes sense to run both even in that case, since pull_request workflow runs for hypothetical merge commit. This helps when source branch is out of date wrt. the target branch. However, dependabot creates the PR right away, so I think we can apply this optimization to its branches. #5608

@adoroszlai adoroszlai merged commit 87b8771 into master Nov 15, 2023
@dependabot dependabot bot deleted the dependabot-maven-org.apache.maven.plugins-maven-clean-plugin-3.3.2 branch November 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants