HDDS-9400. Introduce DatanodeID to avoid passing UUID/String object in SCM #5417
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hdds.protocol; | ||
|
|
||
| import org.apache.hadoop.hdds.protocol.proto.HddsProtos; | ||
| import org.apache.hadoop.hdds.protocol.proto.HddsProtos.DatanodeIDProto; | ||
|
|
||
| import java.util.UUID; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import java.util.concurrent.ConcurrentMap; | ||
|
|
||
| /** | ||
| * DatanodeID is the primary identifier of the Datanode. | ||
| * They are unique for every Datanode in the cluster. | ||
| * <p> | ||
| * This class is immutable and thread safe. | ||
| */ | ||
| public final class DatanodeID implements Comparable<DatanodeID> { | ||
|
|
||
| private static final ConcurrentMap<UUID, DatanodeID> CACHE = new ConcurrentHashMap<>(); | ||
|
|
||
| private final UUID uuid; | ||
| private final String uuidString; | ||
|
||
|
|
||
| private DatanodeID(final UUID uuid) { | ||
| this.uuid = uuid; | ||
| this.uuidString = uuid.toString(); | ||
| } | ||
|
|
||
| // Mainly used for JSON conversion | ||
| public String getID() { | ||
| return toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public int compareTo(final DatanodeID that) { | ||
| return this.uuid.compareTo(that.uuid); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(final Object obj) { | ||
| return obj instanceof DatanodeID && | ||
| uuid.equals(((DatanodeID) obj).uuid); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return uuid.hashCode(); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return uuidString; | ||
| } | ||
|
|
||
| public DatanodeIDProto toProto() { | ||
| return DatanodeIDProto.newBuilder().setUuid(toProto(uuid)).build(); | ||
| } | ||
|
|
||
| public static DatanodeID fromProto(final DatanodeIDProto proto) { | ||
| return of(fromProto(proto.getUuid())); | ||
| } | ||
|
|
||
| public static DatanodeID fromUuidString(final String id) { | ||
| return of(UUID.fromString(id)); | ||
| } | ||
|
|
||
| public static DatanodeID of(final UUID id) { | ||
| return CACHE.computeIfAbsent(id, DatanodeID::new); | ||
| } | ||
|
|
||
| /** | ||
| * Returns a random DatanodeID. | ||
| */ | ||
| public static DatanodeID randomID() { | ||
| // We don't want to add Random ID to cache. | ||
| return new DatanodeID(UUID.randomUUID()); | ||
| } | ||
|
|
||
| private static UUID fromProto(final HddsProtos.UUID id) { | ||
| return new UUID(id.getMostSigBits(), id.getLeastSigBits()); | ||
| } | ||
|
|
||
| private static HddsProtos.UUID toProto(final UUID id) { | ||
| return HddsProtos.UUID.newBuilder() | ||
| .setMostSigBits(id.getMostSignificantBits()) | ||
| .setLeastSigBits(id.getLeastSignificantBits()) | ||
| .build(); | ||
| } | ||
|
|
||
| // TODO: Remove this in follow-up Jira. (HDDS-12015) | ||
| UUID getUuid() { | ||
| return uuid; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.