Skip to content

HDDS-9381. Remove @Flaky annotations from now-stable test cases. #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 6 commits into from
Oct 5, 2023
Merged

HDDS-9381. Remove @Flaky annotations from now-stable test cases. #5390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad2bfa9
HDDS-9381. Remove @flaky annotations from now-stable test cases.
ArafatKhan2198 Oct 4, 2023
0876ef4
Removed Flaky from the TestOzoneFileSystem class
ArafatKhan2198 Oct 4, 2023
4ec6bd9
Removed @flaky from TestSCMContainerPlacementPolicyMetrics
ArafatKhan2198 Oct 5, 2023
fd2f272
Remove @Flaky from TestFailureHandlingByClient for HDDS-7877, HDDS-78…
ArafatKhan2198 Oct 5, 2023
b6c4472
Removed the @flaky annotation from TestMiniOzoneCluster
ArafatKhan2198 Oct 5, 2023
86067a3
Remove @flaky from TestContainerStateMachineFailureOnRead
ArafatKhan2198 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.TestClock;
import org.apache.ozone.test.tag.Flaky;
import org.junit.After;
import org.junit.AfterClass;
import org.junit.Assert;
Expand Down Expand Up @@ -1635,7 +1634,6 @@ public void testDeleteRootWithTrash() throws IOException {
* 2.Verify that the key gets deleted by the trash emptier.
*/
@Test
@Flaky("HDDS-6645")
public void testTrash() throws Exception {
String testKeyName = "testKey2";
Path path = new Path(OZONE_URI_DELIMITER, testKeyName);
Expand Down
3 changes: 0 additions & 3 deletions ...op-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestMiniOzoneCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import org.apache.hadoop.ozone.container.common.statemachine.EndpointStateMachine;
import org.apache.hadoop.ozone.container.common.volume.StorageVolume;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Flaky;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -81,7 +80,6 @@ public void cleanup() {
}

@Test
@Flaky("HDDS-6112")
public void testStartMultipleDatanodes() throws Exception {
final int numberOfNodes = 3;
cluster = MiniOzoneCluster.newBuilder(conf)
Expand Down Expand Up @@ -210,7 +208,6 @@ public void testKeepPortsWhenRestartDN() throws Exception {
* @throws Exception
*/
@Test @Timeout(100)
@Flaky("HDDS-6111")
public void testDNstartAfterSCM() throws Exception {
// Start a cluster with 3 DN
cluster = MiniOzoneCluster.newBuilder(conf)
Expand Down
2 changes: 0 additions & 2 deletions ...t/src/test/java/org/apache/hadoop/ozone/client/rpc/TestBlockOutputStreamWithFailures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
import org.apache.hadoop.ozone.container.ContainerTestHelper;
import org.apache.hadoop.ozone.container.TestHelper;
import org.apache.ozone.test.tag.Flaky;

import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_DEADNODE_INTERVAL;
Expand All @@ -66,7 +65,6 @@
* Tests failure detection and handling in BlockOutputStream Class.
*/
@Timeout(300)
@Flaky("HDDS-1967")
public class TestBlockOutputStreamWithFailures {

private MiniOzoneCluster cluster;
Expand Down
2 changes: 0 additions & 2 deletions .../test/java/org/apache/hadoop/ozone/client/rpc/TestContainerStateMachineFailureOnRead.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import org.apache.hadoop.ozone.container.ozoneimpl.TestOzoneContainer;
import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Flaky;

import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.hadoop.hdds.HddsConfigKeys.HDDS_COMMAND_STATUS_REPORT_INTERVAL;
Expand All @@ -68,7 +67,6 @@
/**
* Test to verify pipeline is closed on readStateMachine failure.
*/
@Flaky("see HDDS-3294")
public class TestContainerStateMachineFailureOnRead {
private MiniOzoneCluster cluster;
private ObjectStore objectStore;
Expand Down
4 changes: 0 additions & 4 deletions ...on-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestFailureHandlingByClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.THREE;
import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_STALENODE_INTERVAL;

import org.apache.ozone.test.tag.Flaky;
import org.junit.Assert;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -165,7 +164,6 @@ public void shutdown() {
}

@Test
@Flaky("HDDS-7877")
public void testBlockWritesWithDnFailures() throws Exception {
startCluster();
String keyName = UUID.randomUUID().toString();
Expand Down Expand Up @@ -355,7 +353,6 @@ public void testWriteSmallFile() throws Exception {


@Test
@Flaky("HDDS-7878")
public void testContainerExclusionWithClosedContainerException()
throws Exception {
startCluster();
Expand Down Expand Up @@ -416,7 +413,6 @@ public void testContainerExclusionWithClosedContainerException()
}

@Test
@Flaky("HDDS-3298")
public void testDatanodeExclusionWithMajorityCommit() throws Exception {
startCluster();
String keyName = UUID.randomUUID().toString();
Expand Down
2 changes: 0 additions & 2 deletions ...doop/ozone/container/common/statemachine/commandhandler/TestCloseContainerByPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import org.junit.jupiter.api.AfterAll;
import org.junit.Assert;
import org.junit.jupiter.api.BeforeAll;
import org.apache.ozone.test.tag.Flaky;
import org.junit.jupiter.api.Test;

import java.io.IOException;
Expand All @@ -64,7 +63,6 @@
/**
* Test container closing.
*/
@Flaky("HDDS-3263")
public class TestCloseContainerByPipeline {

private static MiniOzoneCluster cluster;
Expand Down
2 changes: 0 additions & 2 deletions .../integration-test/src/test/java/org/apache/hadoop/ozone/freon/TestRandomKeyGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
import org.apache.hadoop.hdds.ratis.conf.RatisClientConfig;
import org.apache.hadoop.ozone.MiniOzoneCluster;
import org.apache.ozone.test.tag.Flaky;

import org.junit.Assert;
import org.junit.jupiter.api.AfterAll;
Expand Down Expand Up @@ -218,7 +217,6 @@ void testThreadPoolSize() {
}

@Test
@Flaky("HDDS-5993")
void cleanObjectsTest() {
RandomKeyGenerator randomKeyGenerator =
new RandomKeyGenerator(cluster.getConf());
Expand Down
3 changes: 0 additions & 3 deletions ...gration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAMetadataOnly.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.log4j.Logger;
import org.apache.ozone.test.tag.Flaky;
import org.apache.ratis.protocol.ClientId;
import org.apache.ratis.protocol.Message;
import org.apache.ratis.protocol.RaftClientReply;
Expand Down Expand Up @@ -332,7 +331,6 @@ public void testFailoverWithSuggestedLeader() throws Exception {
}

@Test
@Flaky("HDDS-6644")
public void testReadRequest() throws Exception {
String volumeName = "volume" + RandomStringUtils.randomNumeric(5);
ObjectStore objectStore = getObjectStore();
Expand Down Expand Up @@ -370,7 +368,6 @@ public void testReadRequest() throws Exception {
}

@Test
@Flaky("HDDS-6642")
public void testListVolumes() throws Exception {
String userName = UserGroupInformation.getCurrentUser().getUserName();
ObjectStore objectStore = getObjectStore();
Expand Down
2 changes: 0 additions & 2 deletions ...ne/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestRecursiveAclWithFSO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.apache.hadoop.ozone.security.acl.OzoneObj;
import org.apache.hadoop.ozone.security.acl.OzoneObjInfo;
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.ozone.test.tag.Flaky;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -82,7 +81,6 @@ public void init() throws Exception {
}

@Test
@Flaky("HDDS-8092")
public void testKeyDeleteAndRenameWithoutPermission() throws Exception {
/* r = READ, w = WRITE, c = CREATE, d = DELETE
l = LIST, a = ALL, n = NONE, x = READ_ACL, y = WRITE_ACL */
Expand Down
2 changes: 0 additions & 2 deletions ...est/src/test/java/org/apache/hadoop/ozone/scm/TestSCMContainerPlacementPolicyMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import org.apache.hadoop.ozone.client.OzoneVolume;
import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
import org.apache.hadoop.ozone.om.OMConfigKeys;
import org.apache.ozone.test.tag.Flaky;
import org.junit.jupiter.api.AfterEach;
import org.junit.Assert;
import org.junit.jupiter.api.BeforeEach;
Expand All @@ -68,7 +67,6 @@
/**
* Test cases to verify the metrics exposed by SCMPipelineManager.
*/
@Flaky("HDDS-2961")
public class TestSCMContainerPlacementPolicyMetrics {

private MiniOzoneCluster cluster;
Expand Down