HDDS-2946. Rename audit log should contain both srcKey and dstKey not just key #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Feb 7, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @fapifta for the contribution.
For unit test, I think a good place to add an assertion about audit map contents would be in TestOMKeyRenameRequest. It uses a mock AuditLogger (inherited from TestOMKeyRequest).
elek
approved these changes
Feb 10, 2020
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 thanks the improvement @fapifta and the review @adoroszlai
As it's a small change I will commit it with the existing test, if you open a new Jira to improve the test coverage of this area (as suggested by @adoroszlai ) I promise a quick review ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#478 What changes were proposed in this pull request?
In the audit log of a rename request we just log the key to be renamed. The purpose of this PR is to replace key to srcKey and dstKey in the audit log message in case of a rename.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2946
How was this patch tested?
I haven't find any particular junit test that tests actual audit log messages, and I haven't added one, though I have this patch applied on a cluster, and used the new type of audit log to trace down multiple renames properly. I am happy to discuss how to add a junit test if there is any place for it, and if there is any reason to test the particular queries audit contents, I don't see it necessary as the general facilities we are using for audit log message creation are already tested.