-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-9328. Speed up testListStatusIteratorOnPageSize #5334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sadanand48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for the patch. Moving the tests to a common place sounds like a good idea. We can maybe do it for other tests too in another jira to reduce duplication and have a common place to debug.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
Show resolved
Hide resolved
|
It looks like there is some flakiness (visibility problem?) in FS listing with small page size. |
...op-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java
Show resolved
Hide resolved
|
@sadanand48 patch is updated, please take another look |
sadanand48
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @adoroszlai , LGTM
|
Thanks @sadanand48 for the review (and the fix for HDDS-9347). |
What changes were proposed in this pull request?
Speed up
testListStatusIteratorOnPageSizeby:Also reduce code duplication, extract method to common test class.
https://issues.apache.org/jira/browse/HDDS-9328
How was this patch tested?
Before:
https://github.com/apache/ozone/actions/runs/6245661295/job/16955525758
After:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/6248472464/job/16964041346