-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-6645. Intermittent timeout in TestOzoneFileSystem#testTrash. #5330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ea7d7f to
dc872dd
Compare
|
@devmadhuu @ashishkumar50 Could you please take a look? |
|
Thanks @sadanand48 for the patch.
One question: the patch changes |
Thanks @adoroszlai for pointing. out, updated link for TestOzoneFileSystem run in description. |
ashishkumar50
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadanand48, Thanks for working on this. Please find few comments inline.
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystem.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashPolicyOzone.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java
Show resolved
Hide resolved
ashishkumar50
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadanand48 Thanks for updating the patch, LGTM +1.
aryangupta1998
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1
Thanks @sadanand48 for the patch and @ashishkumar50 for the review!
What changes were proposed in this pull request?
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6645
How was this patch tested?
Unit test
Ran the test successfully for 15x10 = 150 times here : https://github.com/sadanand48/hadoop-ozone/actions/runs/6304966964