Skip to content

Conversation

@tanvipenumudy
Copy link
Contributor

@tanvipenumudy tanvipenumudy commented Sep 12, 2023

What changes were proposed in this pull request?

To introduce a newer listStatus API (we have chosen to introduce a newer API over modifying the existing API as it would break compatibility for older ozone clients) which uses a trimmed KeyInfo [BasicKeyInfo] proto message for excluding fields such as KeyLocations which are not very useful on the client side:

The new lightweight listStatus API would be used for:

  • o3 CLI: (ozone sh key list)
  • S3 ListObject requests

The existing listStatus API will continue being used for:

  • ofs commands
message BasicKeyInfo {
    optional string keyName = 1;
    optional uint64 dataSize = 2;
    optional uint64 creationTime = 3;
    optional uint64 modificationTime = 4;
    optional hadoop.hdds.ReplicationType type = 5;
    optional hadoop.hdds.ReplicationFactor factor = 6;
    optional hadoop.hdds.ECReplicationConfig ecReplicationConfig = 7;
}

This patch shall utilize the server-side Ozone key encapsulations and proto messages introduced as part of HDDS-9079. Implement a lightweight listKeys API (PR #5115).

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7715

How was this patch tested?

@kerneltime
Copy link
Contributor

@tanvipenumudy can you please update rebase this PR?

@tanvipenumudy tanvipenumudy reopened this Sep 27, 2023
@tanvipenumudy tanvipenumudy marked this pull request as ready for review September 27, 2023 06:06
@tanvipenumudy
Copy link
Contributor Author

Rebased the patch. @kerneltime, @duongkame, @adoroszlai could you please take a look at the changes? Thanks!

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanvipenumudy for the patch.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tanvipenumudy for updating the patch. I have one more question on second look.

@adoroszlai
Copy link
Contributor

Thanks @tanvipenumudy for iterating on the patch. I'm fine with the current version. Let's see if others have any comments.

@adoroszlai adoroszlai requested a review from duongkame October 25, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants