-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-7715. Implement a lightweight listStatus API #5275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tanvipenumudy can you please update rebase this PR? |
40e7dbd to
ad176eb
Compare
|
Rebased the patch. @kerneltime, @duongkame, @adoroszlai could you please take a look at the changes? Thanks! |
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanvipenumudy for the patch.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java
Outdated
Show resolved
Hide resolved
…ne/om/OzoneManager.java Co-authored-by: Doroszlai, Attila <[email protected]>
adoroszlai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tanvipenumudy for updating the patch. I have one more question on second look.
...n/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
Outdated
Show resolved
Hide resolved
|
Thanks @tanvipenumudy for iterating on the patch. I'm fine with the current version. Let's see if others have any comments. |
What changes were proposed in this pull request?
To introduce a newer listStatus API (we have chosen to introduce a newer API over modifying the existing API as it would break compatibility for older ozone clients) which uses a trimmed
KeyInfo[BasicKeyInfo] proto message for excluding fields such asKeyLocationswhich are not very useful on the client side:The new lightweight listStatus API would be used for:
o3CLI: (ozone sh key list)The existing listStatus API will continue being used for:
ofscommandsThis patch shall utilize the server-side Ozone key encapsulations and proto messages introduced as part of HDDS-9079. Implement a lightweight listKeys API (PR #5115).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7715
How was this patch tested?