Skip to content

HDDS-9217. Refine certificate renewer service to avoid it scheduled ahead of time #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenSammi merged 1 commit into from
Aug 30, 2023
Merged

HDDS-9217. Refine certificate renewer service to avoid it scheduled ahead of time #5227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ava/org/apache/hadoop/hdds/security/x509/certificate/client/DefaultCertificateClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,7 +1343,9 @@ public synchronized void startCertificateRenewerService() {
this.executorService.scheduleAtFixedRate(
new CertificateRenewerService(false, () -> {
}),
timeBeforeGracePeriod, interval, TimeUnit.MILLISECONDS);
// The Java mills resolution is 1ms, add 1ms to avoid task scheduled
// ahead of time.
timeBeforeGracePeriod + 1, interval, TimeUnit.MILLISECONDS);
getLogger().info("CertificateRenewerService for {} is started with " +
"first delay {} ms and interval {} ms.", component,
timeBeforeGracePeriod, interval);
Expand Down Expand Up @@ -1376,6 +1378,9 @@ public void run() {
Duration timeLeft = timeBeforeExpiryGracePeriod(currentCert);

if (!forceRenewal && !timeLeft.isZero()) {
getLogger().info("Current certificate {} hasn't entered the " +
"renew grace period. Remaining period is {}. ",
currentCert.getSerialNumber().toString(), timeLeft);
return;
}
String newCertId;
Expand Down