Skip to content

HDDS-7275. Improve error logging when blocks cannot be allocated with RATIS THREE. #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
errose28 merged 5 commits into from
Sep 6, 2023
Merged

HDDS-7275. Improve error logging when blocks cannot be allocated with RATIS THREE. #5189

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3280910
HDDS-7275. Improve error logging when blocks cannot be allocated with…
Aug 10, 2023
e6d1196
Merge branch 'apache:master' into HDDS-7275
SaketaChalamchala Aug 15, 2023
45c6b52
HDDS-7275. Removed unnecessary comments.
Aug 15, 2023
21175b5
HDDS-7275. Enriched block allocation failure message with failure rea…
Aug 25, 2023
b39316c
HDDS-7275. Updated the comment as per suggestion.
Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableRatisContainerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ public ContainerInfo getContainer(final long size,
*/

ContainerInfo containerInfo = null;
String failureReason = null;

//TODO we need to continue the refactor to use repConfig everywhere
//in downstream managers.
Expand Down Expand Up @@ -136,11 +137,16 @@ public ContainerInfo getContainer(final long size,
} catch (IOException e) {
LOG.warn("Waiting for one of pipelines {} to be OPEN failed. ",
allocatedPipelineIDs, e);
failureReason = "Waiting for one of pipelines to be OPEN failed. "
+ e.getMessage();
}
} else {
failureReason = se.getMessage();
}
} catch (IOException e) {
LOG.warn("Pipeline creation failed for repConfig: {}. "
+ "Retrying get pipelines call once.", repConfig, e);
failureReason = e.getMessage();
}

pipelineManager.acquireReadLock();
Expand All @@ -166,12 +172,14 @@ public ContainerInfo getContainer(final long size,
}
}

// we have tried all strategies we know and but somehow we are not able
// to get a container for this block. Log that info and return a null.
// we have tried all strategies we know but somehow we are not able
// to get a container for this block. Log that info and throw an exception.
LOG.error(
"Unable to allocate a block for the size: {}, repConfig: {}",
size, repConfig);
return null;
throw new IOException(
"Unable to allocate a container to the block of size: " + size
+ ", replicationConfig: " + repConfig + ". " + failureReason);
}

private List<Pipeline> findPipelinesByState(
Expand Down