Skip to content

HDDS-9090. NullPointerException thrown by ReplicationManagerMetrics because of the order of initialization #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umamaheswararao merged 1 commit into from
Jul 27, 2023
Merged

HDDS-9090. NullPointerException thrown by ReplicationManagerMetrics because of the order of initialization #5126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ public ReplicationManager(final ConfigurationSource conf,
this.ratisReplicationCheckHandler =
new RatisReplicationCheckHandler(ratisContainerPlacement);
this.nodeManager = nodeManager;
this.metrics = ReplicationManagerMetrics.create(this);

ecUnderReplicationHandler = new ECUnderReplicationHandler(
ecContainerPlacement, conf, this);
Expand Down Expand Up @@ -285,7 +286,6 @@ public synchronized void start() {
if (!isRunning()) {
LOG.info("Starting Replication Monitor Thread.");
running = true;
metrics = ReplicationManagerMetrics.create(this);
if (rmConf.isLegacyEnabled()) {
legacyReplicationManager.setMetrics(metrics);
}
Comment on lines -288 to 291
Copy link
Contributor

@adoroszlai adoroszlai Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aswinshakil for the fix. Please note that ReplicationManager can be stopped/restarted by admin from CLI.
stop() unregisters the metrics source, and start() used to (re)create it. But now it isn't re-created, so it won't work after restart. One way to fix this is to add a method in ReplicationManagerMetrics to register it with the metrics system (without creating a new instance), and call this new method from start().

Copy link
Member Author

@aswinshakil aswinshakil Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out @adoroszlai . I wasn't aware of that, feel free to assign the JIRA to me if created, or I can create one.

Copy link
Contributor

@adoroszlai adoroszlai Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aswinshakil, created HDDS-9235.

Expand Down