HDDS-9072. Set isFile when creating OmKeyInfo for createFile code path #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
changed the title
hemantk-12
commented
Jul 24, 2023
...p-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
Show resolved
Hide resolved
prashantpogde
approved these changes
Jul 25, 2023
Contributor
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
This is a good catch. Thanks for the PR @hemantk-12
smengcl
reviewed
Jul 25, 2023
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
Outdated
Show resolved
Hide resolved
aswinshakil
approved these changes
Jul 25, 2023
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for the ptch. LGTM. Pending CI
Contributor
|
Thanks @hemantk-12 for the patch. Thanks @aswinshakil @prashantpogde for reviewing it. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…ile code path (apache#5108) (cherry picked from commit 1b795f5) Change-Id: I83e4230b27007e64cbaed03350c9e99c91c33a06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of change #3912 and #4448,
isFileparameter was added toOmKeyInfoandOzoneKeybut it was not set when new create file gets created it doesn't exist here.This change is to set
isFileon createFile code path so that it can properly identify if key is file or dir.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9072
How was this patch tested?
Updated unit tests.