HDDS-8961. [Snapshot] Added check to allow only Ozone admin user to call print compaction dag #5087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
smengcl
reviewed
Jul 19, 2023
Contributor
There was a problem hiding this comment.
Why the switch? Or should we just print both?
Contributor
Author
There was a problem hiding this comment.
It was my miss in previous PR. backwardCompactionDAG will give the same result as in https://user-images.githubusercontent.com/6820020/211372896-c4f6eada-3fb0-4838-bcc6-08c47606a43f.png
Attaching the images to differentiate.
smengcl
reviewed
Jul 19, 2023
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/CompactionLogDagPrinter.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jul 19, 2023
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jul 19, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @hemantk-12 for the follow-up patch. I have a few comments inline.
hemantk-12
changed the title
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Sep 20, 2023
…in user to call print compaction dag (apache#5087) (cherry picked from commit 607b67e) Change-Id: I81515543062fb129867bba659b430db6321bf301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change addresses few of the concerns raised in PR #5061.
Note: This PR doesn't addressed
Having a network call that generates a file on the server is strange.because of following reason.As we talked in here, it is better to be have it as a OM request to get the in-memory picture of the DAG. It can be solved in following two ways.
Both the solution will require more time and investigation. So for the interest of time, just addressed the security and debug message for now and create a jira: HDDS-9040 for further enhancement.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8961
How was this patch tested?
Existed unit tests.