Skip to content

Conversation

@hemantk-12
Copy link
Contributor

What changes were proposed in this pull request?

This change is to add DB sequence number to the compaction log entry so that it can be used to ignore any newer compaction log entries than the check-pointed active DB's sequence number.
more detail: #4680 (comment)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8652

How was this patch tested?

Updated existing unit tests.

Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smengcl smengcl added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jul 11, 2023
Copy link
Contributor

@prashantpogde prashantpogde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smengcl smengcl merged commit f46f7a7 into apache:master Jul 12, 2023
@smengcl
Copy link
Contributor

smengcl commented Jul 12, 2023

Thanks @hemantk-12 for the patch. Thanks @prashantpogde for the review.

@hemantk-12 hemantk-12 deleted the HDDS-8652 branch October 28, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants