HDDS-8978. SCM SequenceIdGenerator#reinitialize only needs to acquire the lock once #5027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could I ask what are the cases where deadlocks happen, and is this PR #5018 related? |
Contributor
|
The linked Jira is [HDDS-8965], @guohao-rosicky you might need to correct it |
adoroszlai
reviewed
Jul 6, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @guohao-rosicky for working on this.
- Can you please provide more details about the deadlock? It would be great if you could attach a thread dump to the Jira issue.
- Without knowing the details, I don't think the patch fixes any deadlocks.
lockis aReentrantLock. If it islock()-ed twice, it needs to beunlock()-ed twice before it is released. Thuslockis held until return fromreinitialize, whether it callsinvalidateBatchorinvalidateBatchInternal.
Contributor
Author
|
Thanks @adoroszlai for the comment, as you said, I was wrong in my description, this modification reduces the locks by one since reinitialize only needs to acquire the locks once |
guohao-rosicky
changed the title
adoroszlai
reviewed
Jul 14, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @guohao-rosicky for clarifying the intent of this change.
| throws IOException { | ||
| lock.lock(); | ||
| try { | ||
| LOG.info("reinitialize SequenceIdGenerator."); |
Contributor
There was a problem hiding this comment.
I think we should move the log statement out of the lock.
adoroszlai
approved these changes
Jul 19, 2023
Contributor
|
Thanks @guohao-rosicky for the patch, @xichen01, @Xushaohong for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM SequenceIdGenerator#reinitialize only needs to acquire the lock once
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8978