Skip to content

Conversation

@Galsza
Copy link
Contributor

@Galsza Galsza commented Jun 28, 2023

What changes were proposed in this pull request?

Full client side modifications of cert rotation. This depends on at least 3 pull requests rn:
#4961 -- Creating the root CA rotation poller
#5000 -- Adding changes to cert client before it is able to automate root CA rotation
#4943 -- SCM/server side changes for root CA rotation: without this these patches don't make any sense and don't add any functionality.

What is the link to the Apache JIRA

The jira needs to be updated once the previous patches get merged.
HDDS-8593

@Galsza Galsza force-pushed the HDDS-8593_add_root_ca_rotation_poller branch from 08f2222 to 74af9fd Compare June 29, 2023 09:34
@Galsza Galsza changed the title HDDS-8593. Change certificate renewal logic to be able to renew the certificate of a service on demand HDDS-8593. Add RootCARotationPoller to CertClient Jun 29, 2023
@fapifta
Copy link
Contributor

fapifta commented Jun 29, 2023

Thank you @Galsza for sharing this one early on.

I have checked the changes, and I have one note:
The SCMCertificateClient should not start a poller, as SCM's will be notified about the new rootCA via Ratis, and they will act and update their state based on the transactions posted by the leader to the raft ring.

Other than that, the changes looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants