Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export OZONE_DIR=/opt/ozone
# shellcheck source=/dev/null
source "$COMPOSE_DIR/../testlib.sh"

for HADOOP_VERSION in 2.7.3 3.1.2 3.2.2 3.3.5; do
for HADOOP_VERSION in 2.7.3 3.1.2 3.2.2 3.3.6; do
export HADOOP_VERSION
export HADOOP_MAJOR_VERSION=${HADOOP_VERSION%%.*}
# Check if $HADOOP_VERSION starts with the prefix "3.3."
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/compose/ozonesecure-ha/.env
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.

HDDS_VERSION=${hdds.version}
HADOOP_VERSION=3
HADOOP_VERSION=3.3.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the Docker image has the same version as Hadoop itself, we can change this to avoid the need for future updates:

Suggested change
HADOOP_VERSION=3.3.6
HADOOP_VERSION=${hadoop.version}

OZONE_RUNNER_VERSION=${docker.ozone-runner.version}
OZONE_RUNNER_IMAGE=apache/ozone-runner
OZONE_TESTKRB5_IMAGE=${docker.ozone-testkr5b.image}
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/compose/ozonesecure-mr/.env
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

HDDS_VERSION=${hdds.version}
HADOOP_IMAGE=apache/hadoop
HADOOP_VERSION=3.3.5
HADOOP_VERSION=3.3.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HADOOP_VERSION=3.3.6
HADOOP_VERSION=${hadoop.version}

OZONE_RUNNER_VERSION=${docker.ozone-runner.version}
OZONE_RUNNER_IMAGE=apache/ozone-runner
OZONE_TESTKRB5_IMAGE=${docker.ozone-testkr5b.image}
Expand Down
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/compose/ozonesecure/.env
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# limitations under the License.

HDDS_VERSION=${hdds.version}
HADOOP_VERSION=3
HADOOP_VERSION=3.3.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HADOOP_VERSION=3.3.6
HADOOP_VERSION=${hadoop.version}

OZONE_RUNNER_VERSION=${docker.ozone-runner.version}
OZONE_RUNNER_IMAGE=apache/ozone-runner
OZONE_TESTKRB5_IMAGE=${docker.ozone-testkr5b.image}
Expand Down
3 changes: 0 additions & 3 deletions hadoop-ozone/dist/src/main/license/bin/LICENSE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ Apache License 2.0
jakarta.validation:jakarta.validation-api
javax.enterprise:cdi-api
javax.inject:javax.inject
net.minidev:accessors-smart
net.minidev:json-smart
net.java.dev.jna:jna
net.java.dev.jna:jna-platform
org.apache.commons:commons-compress
Expand Down Expand Up @@ -496,7 +494,6 @@ BSD 3-Clause
com.google.re2j:re2j
com.jcraft:jsch
com.thoughtworks.paranamer:paranamer
org.ow2.asm:asm


BSD 2-Clause
Expand Down
45 changes: 21 additions & 24 deletions hadoop-ozone/dist/src/main/license/jar-report.txt
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
share/ozone/lib/accessors-smart.jar
share/ozone/lib/FastInfoset.jar

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Three kinds of changes to jar-report.txt are mixed in this PR.

  1. real dependency changes (see below)
  2. fixing strictly out of alphabetical order items (e.g. hdds-rocks-native)
  3. reordering due to different sort behavior (lowercase/uppercase, chars other than alphabetical) across implementations

I would prefer to stick only to the first kind of change in this PR:

@@ -1,11 +1,9 @@
-share/ozone/lib/accessors-smart.jar
 share/ozone/lib/activation.jar
 share/ozone/lib/animal-sniffer-annotations.jar
 share/ozone/lib/annotations.jar
 share/ozone/lib/annotations.jar
 share/ozone/lib/aopalliance.jar
 share/ozone/lib/aopalliance-repackaged.jar
-share/ozone/lib/asm.jar
 share/ozone/lib/aspectjrt.jar
 share/ozone/lib/aspectjweaver.jar
 share/ozone/lib/awaitility.jar
@@ -156,7 +154,6 @@
 share/ozone/lib/jooq-meta.jar
 share/ozone/lib/jsch.jar
 share/ozone/lib/json-simple.jar
-share/ozone/lib/json-smart.jar
 share/ozone/lib/jsp-api.jar
 share/ozone/lib/jsr305.jar
 share/ozone/lib/jsr311-api.jar

Rationale: The changes are in transitive dependencies, visible only in this file (no POM change). Reordering lines hides the real difference.

Unfortunately dependency check instructs to update the file mention using update-jar-report.sh:

Please update the hadoop-ozone/dist/src/main/license/bin/LICENSE.txt file with the modification
   AND execute hadoop-ozone/dist/src/main/license/update-jar-report.sh when you are ready (after a full build)

which re-generates from scratch, causing such mixed changes. To avoid those, one can simply manually remove the unnecessary entries.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... I wasn't sure how the jar report is generated. Let's see if it is happy with this.

@adoroszlai adoroszlai Jun 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sorts both old (reference) and new lists exactly to avoid false positives due to difference in sort:

#implementation of sort cli is not exactly the same everywhere. It's better to sort with the same command locally
(diff -uw <(sort hadoop-ozone/dist/src/main/license/jar-report.txt) <(sort hadoop-ozone/dist/src/main/license/current.txt) || true ) > "$REPORT_FILE"

So any order is fine as far as dependency check is concerned.

share/ozone/lib/activation.jar
share/ozone/lib/animal-sniffer-annotations.jar
share/ozone/lib/annotations.jar
share/ozone/lib/annotations.jar
share/ozone/lib/aopalliance.jar
share/ozone/lib/aopalliance-repackaged.jar
share/ozone/lib/asm.jar
share/ozone/lib/aopalliance.jar
share/ozone/lib/aspectjrt.jar
share/ozone/lib/aspectjweaver.jar
share/ozone/lib/awaitility.jar
Expand All @@ -26,8 +25,8 @@ share/ozone/lib/commons-configuration2.jar
share/ozone/lib/commons-daemon.jar
share/ozone/lib/commons-digester.jar
share/ozone/lib/commons-io.jar
share/ozone/lib/commons-lang3.jar
share/ozone/lib/commons-lang.jar
share/ozone/lib/commons-lang3.jar
share/ozone/lib/commons-logging.jar
share/ozone/lib/commons-net.jar
share/ozone/lib/commons-pool2.jar
Expand All @@ -41,21 +40,20 @@ share/ozone/lib/disruptor.jar
share/ozone/lib/dnsjava.jar
share/ozone/lib/error_prone_annotations.jar
share/ozone/lib/failureaccess.jar
share/ozone/lib/FastInfoset.jar
share/ozone/lib/gethostname4j.jar
share/ozone/lib/grpc-api.jar
share/ozone/lib/grpc-context.jar
share/ozone/lib/grpc-core.jar
share/ozone/lib/grpc-netty.jar
share/ozone/lib/grpc-protobuf.jar
share/ozone/lib/grpc-protobuf-lite.jar
share/ozone/lib/grpc-protobuf.jar
share/ozone/lib/grpc-stub.jar
share/ozone/lib/gson.jar
share/ozone/lib/guava-jre.jar
share/ozone/lib/guice-assistedinject.jar
share/ozone/lib/guice-bridge.jar
share/ozone/lib/guice.jar
share/ozone/lib/guice-servlet.jar
share/ozone/lib/guice.jar
share/ozone/lib/hadoop-annotations.jar
share/ozone/lib/hadoop-auth.jar
share/ozone/lib/hadoop-common.jar
Expand All @@ -76,8 +74,8 @@ share/ozone/lib/hdds-hadoop-dependency-server.jar
share/ozone/lib/hdds-interface-admin.jar
share/ozone/lib/hdds-interface-client.jar
share/ozone/lib/hdds-interface-server.jar
share/ozone/lib/hdds-rocks-native.jar
share/ozone/lib/hdds-managed-rocksdb.jar
share/ozone/lib/hdds-rocks-native.jar
share/ozone/lib/hdds-server-framework.jar
share/ozone/lib/hdds-server-scm.jar
share/ozone/lib/hdds-tools.jar
Expand All @@ -87,8 +85,8 @@ share/ozone/lib/hk2-utils.jar
share/ozone/lib/hppc.jar
share/ozone/lib/httpasyncclient.jar
share/ozone/lib/httpclient.jar
share/ozone/lib/httpcore.jar
share/ozone/lib/httpcore-nio.jar
share/ozone/lib/httpcore.jar
share/ozone/lib/httpmime.jar
share/ozone/lib/ion-java.jar
share/ozone/lib/istack-commons-runtime.jar
Expand Down Expand Up @@ -148,15 +146,14 @@ share/ozone/lib/jetty-util.jar
share/ozone/lib/jetty-webapp.jar
share/ozone/lib/jetty-xml.jar
share/ozone/lib/jmespath-java.jar
share/ozone/lib/jna.jar
share/ozone/lib/jna-platform.jar
share/ozone/lib/jna.jar
share/ozone/lib/joda-time.jar
share/ozone/lib/jooq-codegen.jar
share/ozone/lib/jooq.jar
share/ozone/lib/jooq-meta.jar
share/ozone/lib/jooq.jar
share/ozone/lib/jsch.jar
share/ozone/lib/json-simple.jar
share/ozone/lib/json-smart.jar
share/ozone/lib/jsp-api.jar
share/ozone/lib/jsr305.jar
share/ozone/lib/jsr311-api.jar
Expand All @@ -173,13 +170,13 @@ share/ozone/lib/log4j-core.jar
share/ozone/lib/metainf-services.jar
share/ozone/lib/metrics-core.jar
share/ozone/lib/netty-buffer.Final.jar
share/ozone/lib/netty-codec.Final.jar
share/ozone/lib/netty-codec-http2.Final.jar
share/ozone/lib/netty-codec-http.Final.jar
share/ozone/lib/netty-codec-http2.Final.jar
share/ozone/lib/netty-codec-socks.Final.jar
share/ozone/lib/netty-codec.Final.jar
share/ozone/lib/netty-common.Final.jar
share/ozone/lib/netty-handler.Final.jar
share/ozone/lib/netty-handler-proxy.Final.jar
share/ozone/lib/netty-handler.Final.jar
share/ozone/lib/netty-resolver.Final.jar
share/ozone/lib/netty-tcnative-boringssl-static.Final-linux-aarch_64.jar
share/ozone/lib/netty-tcnative-boringssl-static.Final-linux-x86_64.jar
Expand All @@ -188,10 +185,10 @@ share/ozone/lib/netty-tcnative-boringssl-static.Final-osx-x86_64.jar
share/ozone/lib/netty-tcnative-boringssl-static.Final-windows-x86_64.jar
share/ozone/lib/netty-tcnative-boringssl-static.Final.jar
share/ozone/lib/netty-tcnative-classes.Final.jar
share/ozone/lib/netty-transport.Final.jar
share/ozone/lib/netty-transport-classes-epoll.Final.jar
share/ozone/lib/netty-transport-native-epoll.Final-linux-x86_64.jar
share/ozone/lib/netty-transport-native-unix-common.Final.jar
share/ozone/lib/netty-transport.Final.jar
share/ozone/lib/nimbus-jose-jwt.jar
share/ozone/lib/okhttp.jar
share/ozone/lib/okio.jar
Expand All @@ -207,25 +204,25 @@ share/ozone/lib/ozone-csi.jar
share/ozone/lib/ozone-datanode.jar
share/ozone/lib/ozone-filesystem-common.jar
share/ozone/lib/ozone-filesystem-hadoop2.jar
share/ozone/lib/ozone-filesystem-hadoop3-client.jar
share/ozone/lib/ozone-filesystem-hadoop3.jar
share/ozone/lib/ozone-filesystem.jar
share/ozone/lib/ozone-httpfsgateway.jar
share/ozone/lib/ozone-filesystem-hadoop3-client.jar
share/ozone/lib/ozone-insight.jar
share/ozone/lib/ozone-interface-client.jar
share/ozone/lib/ozone-interface-storage.jar
share/ozone/lib/ozone-manager.jar
share/ozone/lib/ozone-reconcodegen.jar
share/ozone/lib/ozone-recon.jar
share/ozone/lib/ozone-reconcodegen.jar
share/ozone/lib/ozone-s3-secret-store.jar
share/ozone/lib/ozone-s3gateway.jar
share/ozone/lib/ozone-tools.jar
share/ozone/lib/perfmark-api.jar
share/ozone/lib/picocli.jar
share/ozone/lib/proto-google-common-protos.jar
share/ozone/lib/protobuf-java-util.jar
share/ozone/lib/protobuf-java.jar
share/ozone/lib/protobuf-java.jar
share/ozone/lib/protobuf-java-util.jar
share/ozone/lib/proto-google-common-protos.jar
share/ozone/lib/ranger-intg.jar
share/ozone/lib/ranger-plugin-classloader.jar
share/ozone/lib/ranger-plugins-audit.jar
Expand All @@ -243,12 +240,12 @@ share/ozone/lib/ratis-thirdparty-misc.jar
share/ozone/lib/ratis-tools.jar
share/ozone/lib/re2j.jar
share/ozone/lib/reflections.jar
share/ozone/lib/rocksdb-checkpoint-differ.jar
share/ozone/lib/reload4j.jar
share/ozone/lib/rocksdb-checkpoint-differ.jar
share/ozone/lib/rocksdbjni.jar
share/ozone/lib/simpleclient.jar
share/ozone/lib/simpleclient_common.jar
share/ozone/lib/simpleclient_dropwizard.jar
share/ozone/lib/simpleclient.jar
share/ozone/lib/slf4j-api.jar
share/ozone/lib/slf4j-reload4j.jar
share/ozone/lib/snakeyaml.jar
Expand All @@ -258,12 +255,12 @@ share/ozone/lib/spring-core.jar
share/ozone/lib/spring-jdbc.jar
share/ozone/lib/spring-tx.jar
share/ozone/lib/sqlite-jdbc.jar
share/ozone/lib/stax2-api.jar
share/ozone/lib/stax-ex.jar
share/ozone/lib/stax2-api.jar
share/ozone/lib/txw2.jar
share/ozone/lib/vault-java-driver.jar
share/ozone/lib/weld-servlet-shaded.Final.jar
share/ozone/lib/woodstox-core.jar
share/ozone/lib/zookeeper.jar
share/ozone/lib/zookeeper-jute.jar
share/ozone/lib/zookeeper.jar
share/ozone/lib/zstd-jni.jar
2 changes: 1 addition & 1 deletion hadoop-ozone/dist/src/main/smoketest/.env
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

HADOOP_VERSION=3
HADOOP_VERSION=3.3.6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HADOOP_VERSION=3.3.6
HADOOP_VERSION=${hadoop.version}

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs

<properties>
<hadoop2.version>2.7.3</hadoop2.version>
<hadoop.version>3.3.5</hadoop.version>
<hadoop.version>3.3.6</hadoop.version>

<!-- version for hdds/ozone components -->
<hdds.version>${ozone.version}</hdds.version>
Expand Down