Skip to content

HDDS-8898. Replication limit should not be less than reconstruction weight #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
Jun 22, 2023
Merged

HDDS-8898. Replication limit should not be less than reconstruction weight #4954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4170dc
HDDS-8898. Replication limit should not be less than reconstruction w…
adoroszlai Jun 21, 2023
ef1c277
reference config in error by property name instead of variable name
adoroszlai Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...cm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1333,8 +1333,14 @@ public void validate() {
+ " event.timeout, which is set to " + eventTimeout);
}
if (reconstructionCommandWeight <= 0) {
throw new IllegalArgumentException("reconstructionCommandWeight is"
+ " set to " + reconstructionCommandWeight + " and must be > 0");
throw new IllegalArgumentException("datanode.reconstruction.weight: "
+ reconstructionCommandWeight + " must be > 0");
}
if (datanodeReplicationLimit < reconstructionCommandWeight) {
throw new IllegalArgumentException("datanode.replication.limit: "
+ datanodeReplicationLimit
+ " must be >= datanode.reconstruction.weight: "
+ reconstructionCommandWeight);
}
if (inflightReplicationLimitFactor < 0) {
throw new IllegalArgumentException(
Expand Down