HDDS-6814. ozone s3 getsecret default --om-service-id #4953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice ID configured.
Tejaskriya
changed the title
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Jun 22, 2023
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/s3/S3Handler.java
Outdated
Show resolved
Hide resolved
…/s3/S3Handler.java Co-authored-by: Doroszlai, Attila <[email protected]>
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@Tejaskriya, Mostly change looks good apart from one comment i left.
Also please add command in PR description.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Outdated
Show resolved
Hide resolved
adoroszlai
reviewed
Jun 24, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Tejaskriya for working on this. On second look, I'd like to suggest a few improvements, mostly in the test.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/OzoneAddress.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Jun 27, 2023
Contributor
|
@Tejaskriya Thanks for updating patch, LGTM +1 |
ashishkumar50
approved these changes
Jun 27, 2023
Contributor
|
Thanks @Tejaskriya for the patch, @ashishkumar50, @LZD-PratyushBhatt for the review. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jun 30, 2023
* master: HDDS-8555. [Snapshot] When snapshot feature is disabled, block OM startup if there are still snapshots in the system (apache#4994) HDDS-8782. Improve Volume Scanner Health checks. (apache#4867) HDDS-8447. Datanodes should not process container deletes for failed volumes. (apache#4901) HDDS-5869. Added support for stream on S3Gateway write path (apache#4970) HDDS-8859. [Snapshot] Return failure message to client for a failed snapshot diff jobs (apache#4993) HDDS-8939. [Snapshot] isBlockLocationSame check should be skipped if object is not OmKeyInfo. (apache#4991) HDDS-8923. Expose XceiverClient cache stats as metrics (apache#4979) HDDS-8913. ContainerManagerImpl: reduce processing while locked (apache#4967) HDDS-8935. [Snapshot] Fallback to full diff if getDetlaFiles from compaction DAG fails (apache#4986) HDDS-8911. Update Hadoop to 3.3.6 (apache#4985) HDDS-8931. Allow EC PipelineChoosingPolicy to be defined separately from Ratis (apache#4983) HDDS-8895. Support dynamic change of ozone.readonly.administrators in SCM (apache#4977) HDDS-6814. Make OM service ID optional for `ozone s3` commands if only one is defined in config (apache#4953) HDDS-8925. BaseFreonGenerator may not complete if last attempts fail (apache#4975) HDDS-7100. Container scanner incorrectly marks containers unhealthy when DN is shutdown (apache#4951) HDDS-8919. Allow EC pipelines to be created and then added to PipelineManager in two steps (apache#4968) HDDS-8901. Enable mTLS for InterSCMGrpcProtocol. (apache#4964) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/interfaces/Container.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ContainerTestUtils.java
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
…y one is defined in config (apache#4953)
vtutrinov
pushed a commit
to Cyrill/ozone
that referenced
this pull request
Jul 3, 2023
…y one is defined in config (apache#4953)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For ozone S3 commands, instead of having --om-service-id as a mandatory option, use the serviceID from the config file as the default if there is only one. Otherwise, Make the option a compulsory one.
The usage for non-HA clusters and HA clusters with one service ID:
ozone s3 getsecretAnd usage for HA clusters with multiple service IDs:
ozone s3 getsecret --om-service-id=<omServiceID>What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6814
How was this patch tested?
Added a Robot test for the change.