Skip to content

Conversation

@DaveTeng0
Copy link
Contributor

@DaveTeng0 DaveTeng0 commented Jun 1, 2023

What changes were proposed in this pull request?

Fix issue in : HDDS-8557 Cannot reuse MiniOzoneCluster dir due to RocksDBCheckpointDiffer instance cache

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8557

How was this patch tested?

10 x 10 repetitions of integration test
https://github.com/DaveTeng0/ozone/actions/runs/5139370492

@adoroszlai adoroszlai marked this pull request as draft June 1, 2023 05:13
@adoroszlai
Copy link
Contributor

Thanks @DaveTeng0 for working on this. Please check CI failures.

@hemantk-12
Copy link
Contributor

LGTM.

Thanks for the patch @DaveTeng0.

@DaveTeng0
Copy link
Contributor Author

Currently CI build has a robot test failure related to https://issues.apache.org/jira/browse/HDDS-8732.
Per @swamirishi latest comment, the test should be fixed by merged PR #4678.
I'll merged my branch with latest master branch to rerun the CI tests.

@DaveTeng0 DaveTeng0 marked this pull request as ready for review June 12, 2023 22:18
@aswinshakil aswinshakil changed the title HDDS-8557 Cannot reuse MiniOzoneCluster dir due to RocksDBCheckpointDiffer instance cache HDDS-8557. Cannot reuse MiniOzoneCluster dir due to RocksDBCheckpointDiffer instance cache Jun 14, 2023
@aswinshakil aswinshakil added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Jun 15, 2023
Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for filing this issue. Thanks @DaveTeng0 for the fix. And thanks @hemantk-12 for reviewing this.

CI is green now.

@smengcl smengcl merged commit 3846cd2 into apache:master Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants