Skip to content

HDDS-8729. Add metrics for count of pending Block on DN #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adoroszlai merged 2 commits into from
Jun 8, 2023
Merged

HDDS-8729. Add metrics for count of pending Block on DN #4800

adoroszlai merged 2 commits into from
Jun 8, 2023

Conversation

@xichen01
Copy link
Contributor

@xichen01 xichen01 commented May 30, 2023

What changes were proposed in this pull request?

Add a Metrics to monitor the Pending Block Count.
block_deleting_service_metrics_total_pending_block_count{context="dfs",hostname="centos"} 0

Example:

[root@centos ~/root/ozone]$ curl -s http://127.0.0.1:9882/prom  | grep block_deleting_service_metrics | grep -v '#'
block_deleting_service_metrics_failure_count{context="dfs",hostname="centos"} 0
block_deleting_service_metrics_out_of_order_delete_block_transaction_count{context="dfs",hostname="centos"} 0
block_deleting_service_metrics_success_bytes{context="dfs",hostname="-centos"} 0
block_deleting_service_metrics_success_count{context="dfs",hostname="centos"} 0
block_deleting_service_metrics_total_pending_block_count{context="dfs",hostname="centos"} 0
[root@centos ~/root/ozone]$

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8729

How was this patch tested?

manual test and unit test

Xushaohong
Xushaohong reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@Xushaohong Xushaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a little question commented

...org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java Outdated
public List<ContainerBlockInfo> chooseContainerForBlockDeletion(
int blockLimit, ContainerDeletionChoosingPolicy deletionPolicy)
throws StorageContainerException {
long[] totalPendingBlockCount = new long[1];
Copy link
Contributor

@Xushaohong Xushaohong May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use an array here for a single variable?

Copy link
Contributor Author

@xichen01 xichen01 May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalPendingBlockCount is an array of size 1 because variables used in lambda expressions must be effectively final. Using an array allows you to modify its content inside the lambda while keeping the array reference unchanged.

Copy link
Contributor

@Xushaohong Xushaohong May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@adoroszlai
Copy link
Contributor

adoroszlai commented Jun 1, 2023

@tanvipenumudy please review

@adoroszlai adoroszlai requested review from sumitagrawl and symious June 1, 2023 13:55
@adoroszlai adoroszlai merged commit 030ce66 into apache:master Jun 8, 2023
@adoroszlai
Copy link
Contributor

adoroszlai commented Jun 8, 2023

Thanks @xichen01 for the patch, @symious, @Xushaohong for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Jun 10, 2023
@errose28
Merge branch 'master' into tmp-dir-refactor
ccded0a 
* master: (73 commits)
  HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852)
  HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864)
  HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678)
  HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861)
  HDDS-8373. Document that setquota doesn't accept decimals (apache#4856)
  HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845)
  HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760)
  HDDS-8164. Authorize secret key APIs (apache#4597)
  HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549)
  HDDS-8003. E2E integration test cases for block tokens (apache#4547)
  HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417)
  HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345)
  HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194)
  HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771)
  HDDS-8790. Split EC acceptance tests (apache#4855)
  HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases
  HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854)
  HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840)
  HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800)
  HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850)
  ...
errose28 added a commit to errose28/ozone that referenced this pull request Jun 10, 2023
@errose28
Merge branch 'tmp-dir-refactor' into improve-volume-scanner
b581bc9 
* tmp-dir-refactor: (73 commits)
  HDDS-8587. Test that CertificateClient can store multiple rootCA certificates (apache#4852)
  HDDS-8801. ReplicationManager: Add metric to count how often replication is throttled (apache#4864)
  HDDS-8477. Unit test for Snapdiff using tombstone entries (apache#4678)
  HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (apache#4065) (apache#4861)
  HDDS-8373. Document that setquota doesn't accept decimals (apache#4856)
  HDDS-8779. Recon - Expose flag for enable/disable of heatmap. (apache#4845)
  HDDS-8677. Ozone admin OM CLI command for block tokens (apache#4760)
  HDDS-8164. Authorize secret key APIs (apache#4597)
  HDDS-7945. Integrate secret keys to SCM snapshot (apache#4549)
  HDDS-8003. E2E integration test cases for block tokens (apache#4547)
  HDDS-7831. Use symmetric secret key to sign and verify token (apache#4417)
  HDDS-7830. SCM API for OM and Datanode to get secret keys (apache#4345)
  HDDS-7734. Implement symmetric SecretKeys lifescycle management in SCM (apache#4194)
  HDDS-8679. Add dedicated, configurable thread pool for OM gRPC server (apache#4771)
  HDDS-8790. Split EC acceptance tests (apache#4855)
  HDDS-8714. TestScmHAFinalization: mark testFinalizationWithRestart as flaky, enable other test cases
  HDDS-8787. Reduce ozone sh calls in robot tests (apache#4854)
  HDDS-8774. Log allocation stack trace for leaked CodecBuffer (apache#4840)
  HDDS-8729. Add metric for count of blocks pending deletion on datanode (apache#4800)
  HDDS-8780. Leak of ManagedChannel in HASecurityUtils (apache#4850)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xushaohong Xushaohong Xushaohong left review comments

@symious symious symious left review comments

@adoroszlai adoroszlai adoroszlai approved these changes

@sumitagrawl sumitagrawl Awaiting requested review from sumitagrawl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xichen01 @adoroszlai @Xushaohong @symious