Skip to content

HDDS-2318. Avoid proto::tostring in preconditions to save CPU cycles. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bharatviswa504 merged 2 commits into from
Oct 18, 2019
Merged

HDDS-2318. Avoid proto::tostring in preconditions to save CPU cycles. #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
353bd40
HDDS-2318. Avoid proto::tostring in preconditions to save CPU cycles.
bharatviswa504 Oct 17, 2019
d86a7db
fix findbug and additional changes not needed.
bharatviswa504 Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/utils/OzoneManagerRatisUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ public static OMClientRequest createClientRequest(OMRequest omRequest) {
case GetS3Secret:
return new S3GetSecretRequest(omRequest);
default:
return null;
throw new IllegalStateException("Unrecognized write command " +
"type request" + cmdType);
}
}

Expand Down
2 changes: 0 additions & 2 deletions ...n/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ private OMResponse processRequest(OMRequest request) throws
try {
OMClientRequest omClientRequest =
OzoneManagerRatisUtils.createClientRequest(request);
Preconditions.checkState(omClientRequest != null,
"Unrecognized write command type request" + request.toString());
request = omClientRequest.preExecute(ozoneManager);
} catch (IOException ex) {
// As some of the preExecute returns error. So handle here.
Expand Down