HDDS-8208. [SNAPSHOT] Allow om snapshot bootstrap tarballs to be incremental. #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeJahad
changed the title
GeorgeJahad
changed the title
GeorgeJahad
changed the title
GeorgeJahad
changed the title
smengcl
reviewed
Jun 15, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Thanks @GeorgeJahad for working on this. Overall lgtm. Some comments inline, mostly nits.
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/TestRDBSnapshotProvider.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RDBSnapshotProvider.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RDBSnapshotProvider.java
Show resolved
Hide resolved
| public static final TimeDuration | ||
| OZONE_OM_SNAPSHOT_PROVIDER_REQUEST_TIMEOUT_DEFAULT = | ||
| TimeDuration.valueOf(5000, TimeUnit.MILLISECONDS); | ||
| TimeDuration.valueOf(300000, TimeUnit.MILLISECONDS); |
Contributor
There was a problem hiding this comment.
5s timeout to 5m is quite a jump. If this default config value revision is intended (i.e. not just for debugging), pls change ozone-default.xml correspondingly:
Comment on lines
77
to
78
| assertEquals(tree1Files, tree2Files); | ||
| } |
Contributor
There was a problem hiding this comment.
nit: clean it up by recursively deleting tempDir at the end?
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServlet.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Siyao Meng <[email protected]>
This reverts commit 02166d1.
Contributor
Author
|
@smengcl the checkstyle error is actually because I haven't merged to the latest master. Fixing now. |
Contributor
|
Thanks @GeorgeJahad for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The incremental bootstrapping feature, currently in master, only treats the active fs sst files incrementally. This PR extends that functionality to the om snapshot related sst files.
The feature is currently implemented with an exclude list. The follower generates a list of the active sst files it has currently received from the leader, and passes that list to the leader as part of the next http ratis snapshot request. The leader then excludes those sst files from next tarball it sends to the follower.
In this PR, the follower adds the existing om snapshot sst files to the exclude list. The leader than uses that list to determine which snapshot sst files to exclude as well as which can be used as targets for hard links.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8208
How was this patch tested?
Unit/Integration tests added