HDDS-8497. Add leading zeroes on to report table to optimize get Pagecall of Snapdiff #4722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
reviewed
May 19, 2023
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks for the patch @swamirishi
Left one major (bug) comment and some minor comments.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/PersistentMap.java
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java
Outdated
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java
Outdated
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java
Outdated
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java
Show resolved
Hide resolved
...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
Contributor
|
Blocked by #4678 as well. |
hemantk-12
approved these changes
Jun 20, 2023
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Looks good to me apart from some minor comments I left.
...zone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestRocksDbPersistentMap.java
Outdated
Show resolved
Hide resolved
...zone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestRocksDbPersistentMap.java
Show resolved
Hide resolved
...ne/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Jun 20, 2023
...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
hemantk-12
reviewed
Jun 21, 2023
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the patch.
# Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java
# Conflicts: # hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/RocksDbPersistentMap.java # hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java
prashantpogde
approved these changes
Jun 22, 2023
Contributor
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you for making these changes @swamirishi
szetszwo
reviewed
Jul 29, 2025
Comment on lines
+92
to
+93
| public ClosableIterator<Map.Entry<K, V>> iterator(Optional<K> lowerBound, | ||
| Optional<K> upperBound) { |
Contributor
There was a problem hiding this comment.
Please do not declare parameters with Optional; see https://stackoverflow.com/questions/31922866/why-should-java-8s-optional-not-be-used-in-arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when we fetch a page on job report table from an offset value, we are are doing continuous get calls on the column family since the snapdiff reports pages are not lexicographically ordered. We can use the rocksdb iterator to scan keys on a column family to optimize instead. In order to use this we need to prepend leading zeroes on to the keys to have the pages in lexicographical ordering.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8497
How was this patch tested?
Unit tests written as part of #4678