Skip to content

HDDS-8360. [Snapshot] Increment activeSnapshot count metric only if snapshot creation succeeds #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aswinshakil merged 4 commits into from
May 19, 2023
Merged

HDDS-8360. [Snapshot] Increment activeSnapshot count metric only if snapshot creation succeeds #4721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86b6638
Increment activeSnapshot metric only if snapshot creation succeeds
hemantk-12 May 16, 2023
d60b33f
Addressed code review comment
hemantk-12 May 17, 2023
c4425f7
Merge branch 'master' into HDDS-8360
hemantk-12 May 18, 2023
592631e
Fixed build failure
hemantk-12 May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,

OMMetrics omMetrics = ozoneManager.getMetrics();
omMetrics.incNumSnapshotCreates();
omMetrics.incNumSnapshotActive();

boolean acquiredBucketLock = false, acquiredSnapshotLock = false;
IOException exception = null;
Expand Down Expand Up @@ -228,6 +227,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
if (exception == null) {
LOG.info("Created snapshot '{}' under path '{}'",
snapshotName, snapshotPath);
omMetrics.incNumSnapshotActive();
} else {
omMetrics.incNumSnapshotCreateFails();
LOG.error("Failed to create snapshot '{}' under path '{}'",
Expand Down
1 change: 1 addition & 0 deletions ...er/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotDeleteRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,

final String snapshotPath = snapshotInfo.getSnapshotPath();
if (exception == null) {
omMetrics.decNumSnapshotActive();
LOG.info("Deleted snapshot '{}' under path '{}'",
snapshotName, snapshotPath);
} else {
Expand Down
Loading