HDDS-8587. Prepare CertificateClient to store more than one rootCA certificate #4717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Galsza, is this PR just one new test case? |
Contributor
Author
|
@ChenSammi Yes, we already support to save multiple root ca. This pull request is just to ensure that everything is working properly. I'm going to Prepare TrustManagers to handle multiple root CA certficates soon, which will add real functionality and some more testing. |
fapifta
approved these changes
Jun 6, 2023
Contributor
fapifta
left a comment
fapifta
left a comment
There was a problem hiding this comment.
Thanks for checking this out, and providing a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In preparation for root CA cert rotation, the cert clients need to be able to store more than one root CA certificate. This functionality is already possible, but never actually used. The certs are just saved with the ROOT_CA prefix and their ID. Since the ID is unique, it won't cause collisions.
What is the link to the Apache JIRA
HDDS-8587
How was this patch tested?
Only added testing, which run properly on my work:
https://github.com/Galsza/ozone/actions/runs/4977850423