Skip to content

HDDS-8626. Config thread pool in ReplicationServer #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 4 commits into from
May 16, 2023
Merged

HDDS-8626. Config thread pool in ReplicationServer #4715

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c2cc48
HDDS-8626. Config thread pool in ReplicationServer
guohao-rosicky May 15, 2023
d2d22a9
Merge branch 'apache:master' into guohao-HDDS-8626-dev
guohao-rosicky May 16, 2023
ab00633
change config
guohao-rosicky May 16, 2023
29534c0
find bugs
guohao-rosicky May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion ...ervice/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@
package org.apache.hadoop.ozone.container.replication;

import java.io.IOException;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;

import com.google.common.util.concurrent.ThreadFactoryBuilder;
import org.apache.hadoop.hdds.conf.Config;
import org.apache.hadoop.hdds.conf.ConfigGroup;
import org.apache.hadoop.hdds.conf.ConfigType;
Expand Down Expand Up @@ -62,6 +65,8 @@ public class ReplicationServer {
private int port;
private final ContainerImporter importer;

private ThreadPoolExecutor executor;

public ReplicationServer(ContainerController controller,
ReplicationConfig replicationConfig, SecurityConfig secConf,
CertificateClient caClient, ContainerImporter importer) {
Expand All @@ -70,6 +75,18 @@ public ReplicationServer(ContainerController controller,
this.controller = controller;
this.importer = importer;
this.port = replicationConfig.getPort();

int replicationServerWorkers =
replicationConfig.getReplicationMaxStreams();
this.executor =
new ThreadPoolExecutor(replicationServerWorkers,
replicationServerWorkers,
60, TimeUnit.SECONDS,
new LinkedBlockingQueue<>(),
new ThreadFactoryBuilder().setDaemon(true)
.setNameFormat("ReplicationContainerReader-%d")
.build());

init();
}

Expand All @@ -79,7 +96,8 @@ public void init() {
.addService(ServerInterceptors.intercept(new GrpcReplicationService(
new OnDemandContainerReplicationSource(controller),
importer
), new GrpcServerInterceptor()));
), new GrpcServerInterceptor()))
.executor(executor);

if (secConf.isSecurityEnabled() && secConf.isGrpcTlsEnabled()) {
try {
Expand Down Expand Up @@ -112,6 +130,8 @@ public void start() throws IOException {

public void stop() {
try {
executor.shutdown();
executor.awaitTermination(5L, TimeUnit.SECONDS);
server.shutdown().awaitTermination(10L, TimeUnit.SECONDS);
} catch (InterruptedException ex) {
LOG.warn("{} couldn't be stopped gracefully", getClass().getSimpleName());
Expand Down