HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM#4642

Merged

smengcl merged 18 commits intoapache:masterfrom

smengcl:HDDS-8166-snapshot-config

May 5, 2023

Commits on May 3, 2023

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM
smengcl
committed

Commits on May 4, 2023

Address comment 1.
smengcl
committed
More docker compose config additions.
smengcl
committed
Add new Aspect SnapshotFeatureEnabled.
smengcl
committed
Clean up Aspect impl and test.
smengcl
committed
More test changes to enable snapshot feature explicitly.
smengcl
committed
omSnapshotManager can't easily be null due to the usage in OMDirectoriesPurgeRequestWithFSO#validateAndUpdateCache -- can lead to inconsistency when OM is recovering from Ratis log if skipped.
smengcl
committed
Even more test changes to enable snapshot feature explicitly.
smengcl
committed
Add comments for HDDS-8529; add debug logging when omSnapshotManager is null; findbugs.
smengcl
committed
Add workaround for HDDS-8529.
smengcl
committed
Rename `SnapshotFeatureEnabled` to `RequireSnapshotFeatureState`; comment and code clean up.
smengcl
committed
Add debug logging in RequireSnapshotFeatureStateAspect.
smengcl
committed
Add one more `omSnapshotManager` null check in `installCheckpoint`.
smengcl
committed
Can't disable `omSnapshotManager` as all read paths now requires `omSnapshotManager.checkForSnapshot`; Just disables `snapshotDiffCleanupService` for now.
smengcl
committed
Disallow snapshot access when feature is disabled by forcing `OmSnapshotManager#checkForSnapshot` to return active DB OmMetadataReader instance.
smengcl
committed
Remove workaround now that `omSnapshotManager` won't be null.
smengcl
committed
Revert `omSnapshotManager` null handling; add integration test.
smengcl
committed
Merge remote-tracking branch 'asf/master' into HDDS-8166-snapshot-config
smengcl
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM#4642

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM#4642
smengcl merged 18 commits intoapache:masterfrom
smengcl:HDDS-8166-snapshot-config

Commits on May 3, 2023

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM

Commits on May 4, 2023

Address comment 1.

More docker compose config additions.

Add new Aspect SnapshotFeatureEnabled.

Clean up Aspect impl and test.

More test changes to enable snapshot feature explicitly.

omSnapshotManager can't easily be null due to the usage in OMDirectoriesPurgeRequestWithFSO#validateAndUpdateCache -- can lead to inconsistency when OM is recovering from Ratis log if skipped.

Even more test changes to enable snapshot feature explicitly.

Add comments for HDDS-8529; add debug logging when omSnapshotManager is null; findbugs.

Add workaround for HDDS-8529.

Rename `SnapshotFeatureEnabled` to `RequireSnapshotFeatureState`; comment and code clean up.

Add debug logging in RequireSnapshotFeatureStateAspect.

Add one more `omSnapshotManager` null check in `installCheckpoint`.

Can't disable `omSnapshotManager` as all read paths now requires `omSnapshotManager.checkForSnapshot`; Just disables `snapshotDiffCleanupService` for now.

Disallow snapshot access when feature is disabled by forcing `OmSnapshotManager#checkForSnapshot` to return active DB OmMetadataReader instance.

Remove workaround now that `omSnapshotManager` won't be null.

Revert `omSnapshotManager` null handling; add integration test.

Merge remote-tracking branch 'asf/master' into HDDS-8166-snapshot-config

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM#4642smengcl merged 18 commits intoapache:masterapache/ozone:masterfrom smengcl:HDDS-8166-snapshot-configsmengcl/hadoop-ozone:HDDS-8166-snapshot-configCopy head branch name to clipboard

Commits

Commits on May 3, 2023

Commits on May 4, 2023

HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM#4642
smengcl merged 18 commits intoapache:masterfrom
smengcl:HDDS-8166-snapshot-config