Skip to content

Conversation

@sumitagrawl
Copy link
Contributor

What changes were proposed in this pull request?

manual WAL setting for SCM rocksdb

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8469

How was this patch tested?

UT and integration test. Performance test.

manual WAL performance is 3-4 times slower than batch Operation

  • Adding 100,000 records: 2.8 times slower
  • Add/Delete same records 100,000: 5 times slower
  • Delete 100,000 records: 9 times slower
  • Overwrite same key 100,000 times: 4.5 times slower

@sumitagrawl sumitagrawl marked this pull request as draft April 24, 2023 16:05
@sumitagrawl sumitagrawl changed the title Hdds 8469 HDDS-8469. SCM using WAL manual flush of rocksDB Apr 24, 2023
@kerneltime
Copy link
Contributor

@swamirishi can you please review the design as well?

Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the performance of WAL manual flush is not good. Let's choose a different solution (probably #3) in HDDS-8485?

@adoroszlai
Copy link
Contributor

/pending

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

/pending

@github-actions
Copy link

github-actions bot commented Feb 5, 2024

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."

@github-actions github-actions bot closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants