HDDS-8411. Show the total number of CLOSING, QUASI_CLOSED, CLOSED, DELETING Containers in Recon #4591
Conversation
dombizita
changed the title
|
@targetoee - Thanks for working on this patch, however transitioning of container states could be very fast in a busy cluster, and not sure how much this info will be useful to show CLOSING, QUASI_CLOSED and DELETING containers count. We show OPEN container count already and total container count, so difference will give us CLOSED container count. |
| .setClosingContainers(containerStateCounts.getClosingContainersCount()) | ||
| .setQuasiClosedContainers( | ||
| containerStateCounts.getQuasiClosedContainersCount()) | ||
| .setClosedContainers(containerStateCounts.getClosedContainersCount()) |
There was a problem hiding this comment.
This may not be needed, as difference of total and open will give us closed container count. Rest all information on container states can be easily found out using Ozone admin CLI because we don't want to expose the transitioning container states to other users, and should be exposed to Admin users only.
There was a problem hiding this comment.
Hi @devmadhuu
@sumitagrawl has suggested that we include additional states in our state counts, such as close, closing, and quasi_closed. The state closing is especially important and can provide valuable insights into the situation being analyzed.
There was a problem hiding this comment.
@ArafatKhan2198 , these state transitions are too dynamic and quick, let's discuss this, not sure if in so dynamic transitions, if it is really useful for admins. Moreover these are directly queried using admin CLI, so better we should avoid such data and load recon
There was a problem hiding this comment.
Also closed is not needed because it can be derived from difference
There was a problem hiding this comment.
IMO, Quasi-Closed can be important state having special meaning. Also Closing / Deleting if stuck can be identified easily from this perspective.
There was a problem hiding this comment.
Yes in normal scenarios transition will be quick, but have seen large number of containers stuck and remaining in Closing state in some scenarios. So should be useful for analyzing, if easily visible. But we should be careful of cluttering overview page and should have at appropriate place.
| .setClosedContainers(containerStateCounts.getClosedContainersCount()) | ||
| .setDeletingContainers( | ||
| containerStateCounts.getDeletingContainersCount()) | ||
| .setDeletedContainers(containerStateCounts.getDeletedContainersCount()) |
There was a problem hiding this comment.
Deleted Container and Deleting container shows different info ... and not to be excluded from container count. Only Deleted Container needs to be excluded,
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
@ArafatKhan2198 Thanks for working on this, plz check my opinion
| .setClosingContainers(containerStateCounts.getClosingContainersCount()) | ||
| .setQuasiClosedContainers( | ||
| containerStateCounts.getQuasiClosedContainersCount()) | ||
| .setClosedContainers(containerStateCounts.getClosedContainersCount()) |
There was a problem hiding this comment.
IMO, Quasi-Closed can be important state having special meaning. Also Closing / Deleting if stuck can be identified easily from this perspective.
| .setClosedContainers(containerStateCounts.getClosedContainersCount()) | ||
| .setDeletingContainers( | ||
| containerStateCounts.getDeletingContainersCount()) | ||
| .setDeletedContainers(containerStateCounts.getDeletedContainersCount()) |
There was a problem hiding this comment.
Deleted Container and Deleting container shows different info ... and not to be excluded from container count. Only Deleted Container needs to be excluded,
|
/pending |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
6 participants
What changes were proposed in this pull request?
This PR adds additional container information to Recon, which shows the total count of containers in some states, including CLOSING, QUASI_CLOSED, CLOSED, and DELETING.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8411
How was this patch tested?
Unit test
