Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

$ mvn -am -pl :ozone-integration-test -Dtest='TestOMDbCheckpointServlet' clean test
...
$ grep 'not closed properly' hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet-output.txt 
2023-04-15 18:42:50,134 [Finalizer] WARN  managed.ManagedRocksObjectUtils (ManagedRocksObjectUtils.java:assertClosed(54)) - Checkpoint is not closed properly

https://issues.apache.org/jira/browse/HDDS-8429

How was this patch tested?

$ mvn -am -pl :ozone-integration-test -Dtest='TestOMDbCheckpointServlet' clean test
...
$ grep 'not closed properly' hadoop-ozone/integration-test/target/surefire-reports/org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet-output.txt 

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4708820465

@adoroszlai adoroszlai self-assigned this Apr 16, 2023
@adoroszlai adoroszlai added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Apr 16, 2023
@adoroszlai adoroszlai requested a review from smengcl April 16, 2023 08:51
@adoroszlai
Copy link
Contributor Author

@GeorgeJahad @hemantk-12 please review

@GeorgeJahad
Copy link
Contributor

LGTM @adoroszlai Thanks for cleaning this up. Sorry for the inconvenience

Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @adoroszlai

Lgtm +1.

@adoroszlai adoroszlai requested a review from aswinshakil April 17, 2023 19:59
@adoroszlai adoroszlai added the bug Something isn't working label Apr 18, 2023
@adoroszlai adoroszlai requested a review from dombizita April 18, 2023 07:37
Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this @adoroszlai, it looks good to me!

@adoroszlai adoroszlai merged commit 93cdbfe into apache:master Apr 18, 2023
@adoroszlai adoroszlai deleted the HDDS-8429 branch April 18, 2023 14:46
@adoroszlai
Copy link
Contributor Author

Thanks @dombizita, @GeorgeJahad, @hemantk-12 for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Apr 20, 2023
* master: (440 commits)
  HDDS-8445. Move PlacementPolicy back to SCM (apache#4588)
  HDDS-8335. ReplicationManager: EC Mis and Under replication handlers should handle overloaded exceptions (apache#4593)
  HDDS-8355. Intermittent failure in TestOMRatisSnapshots#testInstallSnapshot (apache#4592)
  HDDS-8444. Increase timeout of CI build (apache#4586)
  HDDS-8446. Selective checks: handle change in ci.yaml (apache#4587)
  HDDS-8440. Ozone Manager crashed with ClassCastException when deleting FSO bucket. (apache#4582)
  HDDS-7309. Enable by default GRPC between S3G and OM (apache#3820)
  HDDS-8458. Mark TestBlockDeletion#testBlockDeletion as flaky
  HDDS-8385. Ozone can't process snapshot when service UID > 2097151 (apache#4580)
  HDDS-8424: Preserve legacy bucket getKeyInfo behavior (apache#4576)
  HDDS-8453. Mark TestDirectoryDeletingServiceWithFSO#testDirDeletedTableCleanUpForSnapshot as flaky
  HDDS-8137. [Snapshot] SnapDiff to use tombstone entries in SST files (apache#4376)
  HDDS-8270. Measure checkAccess latency for Ozone objects (apache#4467)
  HDDS-8109. Seperate Ratis and EC MisReplication Handling (apache#4577)
  HDDS-8429. Checkpoint is not closed properly in OMDBCheckpointServlet (apache#4575)
  HDDS-8253. Set ozone.metadata.dirs to temporary dir if not defined in S3 Gateway (apache#4455)
  HDDS-8400. Expose rocksdb last sequence number through metrics (apache#4557)
  HDDS-8333. ReplicationManager: Allow partial EC reconstruction if insufficient nodes available (apache#4579)
  HDDS-8147. Introduce latency metrics for S3 Gateway operations (apache#4383)
  HDDS-7908. Support OM Metadata operation Generator in `Ozone freon` (apache#4251)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants