Skip to content

Conversation

@smitajoshi12
Copy link
Contributor

What changes were proposed in this pull request?

This information will be displayed on the overview page of recon which gets populated with the information provided by the ClusterStateEndpoint

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-8340

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

Manually
image

@dombizita dombizita changed the title HDDS-8340. Recon Show the number of keys marked for Deletion in Recon UI. HDDS-8340. Recon Show the number of containers that have been DELETED in UI. Apr 11, 2023
@dombizita dombizita self-requested a review April 11, 2023 15:30
@kerneltime kerneltime requested a review from fapifta April 17, 2023 16:07
@kerneltime
Copy link
Contributor

@devmadhuu @xBis7 can you'll please take a look?

@xBis7
Copy link
Contributor

xBis7 commented Apr 17, 2023

IMHO, displaying the number of missing containers would be much more useful than the number of deleted containers. Does it make more sense to see how many of the existing containers have gone missing or are unhealthy? Or how many data you didn't need and eventually deleted?

@smitajoshi12
Copy link
Contributor Author

IMHO, displaying the number of missing containers would be much more useful than the number of deleted containers. Does it make more sense to see how many of the existing containers have gone missing or are unhealthy? Or how many data you didn't need and eventually deleted?

@xBis7
Missing Containers functionality is already implemented in overview page.

image

@devmadhuu
Copy link
Contributor

IMHO, displaying the number of missing containers would be much more useful than the number of deleted containers. Does it make more sense to see how many of the existing containers have gone missing or are unhealthy? Or how many data you didn't need and eventually deleted?

@xBis7 Thanks for your review, I think Recon displays the missing containers and unhealthy containers under "Containers" tab. This PR is mainly focussed to show count on Overview page.

@xBis7
Copy link
Contributor

xBis7 commented Apr 18, 2023

I think Recon displays the missing containers and unhealthy containers under "Containers" tab. This PR is mainly focussed to show count on Overview page.

@devmadhuu I know and also there is the number of containers next to each tab header (missing, under-replicated, ...). Why would the user want to see the number of deleted containers?

@devmadhuu
Copy link
Contributor

I think Recon displays the missing containers and unhealthy containers under "Containers" tab. This PR is mainly focussed to show count on Overview page.

@devmadhuu I know and also there is the number of containers next to each tab header (missing, under-replicated, ...). Why would the user want to see the number of deleted containers?

@xBis7 as far as i know , this count of deleted containers was done based on multiple issues being faced while debugging customer issues, so needed this info to correlate with information in rocks db. Mainly targeted for admin users not for direct customers.

@xBis7
Copy link
Contributor

xBis7 commented Apr 18, 2023

this count of deleted containers was done based on multiple issues being faced while debugging customer issues, so needed this info to correlate with information in rocks db. Mainly targeted for admin users not for direct customers.

@devmadhuu Thanks for the info. Based on that, this PR looks good.

CI failure seems unrelated.

… in UI revert changes for undefined condition
Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this @smitajoshi12, it looks good to me!

@smengcl smengcl changed the title HDDS-8340. Recon Show the number of containers that have been DELETED in UI. HDDS-8340. [Recon] Show the number of deleted containers in UI May 4, 2023
@smengcl smengcl merged commit 1fda945 into apache:master May 4, 2023
@smengcl
Copy link
Contributor

smengcl commented May 4, 2023

Thanks @smitajoshi12 for the addition. Thanks @xBis7 @devmadhuu @dombizita for the reviews.

@smitajoshi12 smitajoshi12 deleted the HDDS-8340 branch May 22, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants