-
Notifications
You must be signed in to change notification settings - Fork 587
HDDS-8340. [Recon] Show the number of deleted containers in UI #4555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… in UI check undefined
|
@devmadhuu @xBis7 can you'll please take a look? |
|
IMHO, displaying the number of missing containers would be much more useful than the number of deleted containers. Does it make more sense to see how many of the existing containers have gone missing or are unhealthy? Or how many data you didn't need and eventually deleted? |
@xBis7 |
@xBis7 Thanks for your review, I think Recon displays the missing containers and unhealthy containers under "Containers" tab. This PR is mainly focussed to show count on Overview page. |
@devmadhuu I know and also there is the number of containers next to each tab header (missing, under-replicated, ...). Why would the user want to see the number of deleted containers? |
@xBis7 as far as i know , this count of deleted containers was done based on multiple issues being faced while debugging customer issues, so needed this info to correlate with information in rocks db. Mainly targeted for admin users not for direct customers. |
@devmadhuu Thanks for the info. Based on that, this PR looks good. CI failure seems unrelated. |
...ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
Outdated
Show resolved
Hide resolved
… in UI revert changes for undefined condition
dombizita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this @smitajoshi12, it looks good to me!
|
Thanks @smitajoshi12 for the addition. Thanks @xBis7 @devmadhuu @dombizita for the reviews. |

What changes were proposed in this pull request?
This information will be displayed on the overview page of recon which gets populated with the information provided by the ClusterStateEndpoint
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8340
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
Manually
